widl: Tweak the rules for when to call pfnFree for arrays.

Varying arrays that aren't unmarshalled shouldn't be freed, but conformant arrays that aren't unmarshalled should.

widl: Tweak the rules for when to call pfnFree for arrays.
b57a322b · Rob Shearman · Alexandre Julliard · a4269c8e · b57a322b
Commit b57a322b authored Dec 21, 2007 by Rob Shearman Committed by Alexandre Julliard Dec 21, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

typegen.c tools/widl/typegen.c +4 -3

No files found.
--- a/tools/widl/typegen.c
+++ b/tools/widl/typegen.c
@@ -2765,9 +2765,10 @@ static void write_remoting_arg(FILE *file, int indent, const func_t *func,
        {
            /* these are all unmarshalled by pointing into the buffer on the
             * server side */
-            if (type->type != RPC_FC_SMFARRAY &&
-                type->type != RPC_FC_LGFARRAY &&
-                type->type != RPC_FC_CARRAY)
+            if (type->type == RPC_FC_BOGUS_ARRAY ||
+                type->type == RPC_FC_CVARRAY ||
+                (type->type == RPC_FC_SMVARRAY && type->type == RPC_FC_LGVARRAY && in_attr) ||
+                (type->type == RPC_FC_CARRAY && type->type == RPC_FC_CARRAY && !in_attr))
            {
                print_file(file, indent, "if (%s)\n", var->name);
                indent++;