winedump: Fix potential null-pointer dereference (cppcheck).

Signed-off-by: Fabian Maurer <dark.shadow4@web.de> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winedump: Fix potential null-pointer dereference (cppcheck).
b58094f7 · Fabian Maurer · Alexandre Julliard · fe2d4509 · b58094f7
Commit b58094f7 authored Oct 03, 2017 by Fabian Maurer Committed by Alexandre Julliard Oct 03, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

pdb.c tools/winedump/pdb.c +2 -1

No files found.
--- a/tools/winedump/pdb.c
+++ b/tools/winedump/pdb.c
@@ -215,7 +215,8 @@ static void *read_string_table(struct pdb_reader* reader)
    stream_idx = get_stream_by_name(reader, "/names");
    if (stream_idx == -1) return NULL;
    ret = reader->read_file(reader, stream_idx);
-    if (ret && *(const DWORD*)ret == 0xeffeeffe) return ret;
+    if (!ret) return NULL;
+    if(*(const DWORD*)ret == 0xeffeeffe) return ret;
    printf("wrong header %x expecting 0xeffeeffe\n", *(const DWORD*)ret);
    free( ret );
    return NULL;