qcap/tests: Remove duplicated tests for allocator identity.

We test once above that the source does not use the existing allocator, but then implicitly release the allocator we are testing against (when the source assigns a new allocator to the sink). As a result, these ok() statements were testing that newly allocated allocators had a different address than the original allocator, which of course sometimes fails. Since we don't need to perform this test more than once anyway, just get rid of the offending ok() statements.

qcap/tests: Remove duplicated tests for allocator identity.
bc9c8684 · Zebediah Figura · Alexandre Julliard · 51c5f44b · bc9c8684
Commit bc9c8684 authored May 23, 2023 by Zebediah Figura Committed by Alexandre Julliard May 23, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 4 deletions

audiorecord.c dlls/qcap/tests/audiorecord.c +0 -4

No files found.
--- a/dlls/qcap/tests/audiorecord.c
+++ b/dlls/qcap/tests/audiorecord.c
@@ -705,8 +705,6 @@ static void test_source_allocator(IFilterGraph2 *graph, IMediaControl *control,
    hr = IFilterGraph2_ConnectDirect(graph, source, &testsink->sink.pin.IPin_iface, &mt);
    ok(hr == S_OK, "Got hr %#lx.\n", hr);

-    todo_wine ok(testsink->sink.pAllocator && testsink->sink.pAllocator != allocator,
-            "Got unexpected allocator %p.\n", testsink->sink.pAllocator);
    hr = IMemAllocator_GetProperties(testsink->sink.pAllocator, &props);
    ok(hr == S_OK, "Got hr %#lx.\n", hr);
    ok(props.cBuffers == req_props.cBuffers, "Got %ld buffers.\n", props.cBuffers);
@@ -728,8 +726,6 @@ static void test_source_allocator(IFilterGraph2 *graph, IMediaControl *control,
        hr = IFilterGraph2_ConnectDirect(graph, source, &testsink->sink.pin.IPin_iface, &mt);
        ok(hr == S_OK, "Got hr %#lx.\n", hr);

-        todo_wine ok(testsink->sink.pAllocator && testsink->sink.pAllocator != allocator,
-                "Got unexpected allocator %p.\n", testsink->sink.pAllocator);
        hr = IMemAllocator_GetProperties(testsink->sink.pAllocator, &props);
        ok(hr == S_OK, "Got hr %#lx.\n", hr);
        ok(props.cBuffers == 4, "Got %ld buffers.\n", props.cBuffers);