shlwapi/tests: Test NULL UrlCanonicalizeA/W() parameters.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

shlwapi/tests: Test NULL UrlCanonicalizeA/W() parameters.
c169263b · Zhiyi Zhang · Alexandre Julliard · 3cbd9cda · c169263b
Commit c169263b authored May 18, 2020 by Zhiyi Zhang Committed by Alexandre Julliard May 18, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 32 additions and 0 deletions

url.c dlls/shlwapi/tests/url.c +32 -0

No files found.
--- a/dlls/shlwapi/tests/url.c
+++ b/dlls/shlwapi/tests/url.c
@@ -1052,6 +1052,22 @@ static void test_UrlCanonicalizeA(void)

    urllen = lstrlenA(winehqA);

+    /* Parameter checks */
+    dwSize = ARRAY_SIZE(szReturnUrl);
+    hr = pUrlCanonicalizeA(NULL, szReturnUrl, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    dwSize = ARRAY_SIZE(szReturnUrl);
+    hr = pUrlCanonicalizeA(winehqA, NULL, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    hr = pUrlCanonicalizeA(winehqA, szReturnUrl, NULL, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    dwSize = 0;
+    hr = pUrlCanonicalizeA(winehqA, szReturnUrl, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
    /* buffer has no space for the result */
    dwSize=urllen-1;
    memset(szReturnUrl, '#', urllen+4);
@@ -1137,6 +1153,22 @@ static void test_UrlCanonicalizeW(void)
    }
    urllen = lstrlenW(winehqW);

+    /* Parameter checks */
+    dwSize = ARRAY_SIZE(szReturnUrl);
+    hr = pUrlCanonicalizeW(NULL, szReturnUrl, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    dwSize = ARRAY_SIZE(szReturnUrl);
+    hr = pUrlCanonicalizeW(winehqW, NULL, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    hr = pUrlCanonicalizeW(winehqW, szReturnUrl, NULL, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
+    dwSize = 0;
+    hr = pUrlCanonicalizeW(winehqW, szReturnUrl, &dwSize, URL_UNESCAPE);
+    ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
    /* buffer has no space for the result */
    dwSize = (urllen-1);
    memset(szReturnUrl, '#', (urllen+4) * sizeof(WCHAR));