scrrun: Fix use-after-free of version info (Valgrind).

c50503d0 · Nikolay Sivov · Alexandre Julliard · a596cbb8 · c50503d0
Commit c50503d0 authored May 05, 2014 by Nikolay Sivov Committed by Alexandre Julliard May 05, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

filesystem.c dlls/scrrun/filesystem.c +5 -1

No files found.
--- a/dlls/scrrun/filesystem.c
+++ b/dlls/scrrun/filesystem.c
@@ -3657,11 +3657,15 @@ static HRESULT WINAPI filesys_GetFileVersion(IFileSystem3 *iface, BSTR name, BST
    }

    ret = VerQueryValueW(ptr, rootW, (void**)&info, &len);
-    heap_free(ptr);
    if (!ret)
+    {
+        heap_free(ptr);
        return HRESULT_FROM_WIN32(GetLastError());
+    }

    get_versionstring(info, ver);
+    heap_free(ptr);
+
    *version = SysAllocString(ver);
    TRACE("version=%s\n", debugstr_w(ver));