Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
cac26d47
Commit
cac26d47
authored
Nov 16, 2012
by
Frédéric Delanoy
Committed by
Alexandre Julliard
Nov 16, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix leaks in stop_service_dependents (coverity).
parent
499c5317
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
7 deletions
+10
-7
action.c
dlls/msi/action.c
+10
-7
No files found.
dlls/msi/action.c
View file @
cac26d47
...
...
@@ -6043,6 +6043,7 @@ static BOOL stop_service_dependents(SC_HANDLE scm, SC_HANDLE service)
ENUM_SERVICE_STATUSW
*
dependencies
;
SERVICE_STATUS
ss
;
SC_HANDLE
depserv
;
BOOL
stopped
,
ret
=
FALSE
;
if
(
EnumDependentServicesW
(
service
,
SERVICE_ACTIVE
,
NULL
,
0
,
&
needed
,
&
count
))
...
...
@@ -6057,24 +6058,26 @@ static BOOL stop_service_dependents(SC_HANDLE scm, SC_HANDLE service)
if
(
!
EnumDependentServicesW
(
service
,
SERVICE_ACTIVE
,
dependencies
,
needed
,
&
needed
,
&
count
))
goto
error
;
goto
done
;
for
(
i
=
0
;
i
<
count
;
i
++
)
{
depserv
=
OpenServiceW
(
scm
,
dependencies
[
i
].
lpServiceName
,
SERVICE_STOP
|
SERVICE_QUERY_STATUS
);
if
(
!
depserv
)
goto
error
;
goto
done
;
if
(
!
ControlService
(
depserv
,
SERVICE_CONTROL_STOP
,
&
ss
))
goto
error
;
stopped
=
ControlService
(
depserv
,
SERVICE_CONTROL_STOP
,
&
ss
);
CloseServiceHandle
(
depserv
);
if
(
!
stopped
)
goto
done
;
}
ret
urn
TRUE
;
ret
=
TRUE
;
error
:
done
:
msi_free
(
dependencies
);
return
FALSE
;
return
ret
;
}
static
UINT
stop_service
(
LPCWSTR
name
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment