comdlg32: Check for overflow before dereferencing.

Signed-off-by: Pierre Schweitzer <pierre@reactos.org> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

comdlg32: Check for overflow before dereferencing.
d288d8d3 · Pierre Schweitzer · Alexandre Julliard · 1c31ba25 · d288d8d3
Commit d288d8d3 authored May 01, 2016 by Pierre Schweitzer Committed by Alexandre Julliard May 02, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

filedlg.c dlls/comdlg32/filedlg.c +1 -1

No files found.
--- a/dlls/comdlg32/filedlg.c
+++ b/dlls/comdlg32/filedlg.c
@@ -650,7 +650,7 @@ int COMDLG32_SplitFileNames(LPWSTR lpstrEdit, UINT nStrLen, LPWSTR *lpstrFileLis
 	  if ( lpstrEdit[nStrCharCount]=='"' )
 	  {
 	    nStrCharCount++;
-	    while ((lpstrEdit[nStrCharCount]!='"') && (nStrCharCount <= nStrLen))
+	    while ((nStrCharCount <= nStrLen) && (lpstrEdit[nStrCharCount]!='"'))
 	    {
 	      (*lpstrFileList)[nFileIndex++] = lpstrEdit[nStrCharCount];
 	      nStrCharCount++;