Skip to content

W
wine-cw
Commit d78ee14b authored by Alexandre Julliard's avatar Alexandre Julliard
Browse files
Options

Print a warning when DllRegisterServer and similar functions are not

marked private.
parent fa70d5c0
Hide whitespace changes
Inline Side-by-side
Showing with 11 additions and 0 deletions
tools/winebuild/parser.c
View file @ d78ee14b
...@@ -513,6 +513,17 @@ static int parse_spec_ordinal( int ordinal, DLLSPEC *spec ) ...@@ -513,6 +513,17 @@ static int parse_spec_ordinal( int ordinal, DLLSPEC *spec )
odp->ordinal = ordinal; odp->ordinal = ordinal;
} }
if (odp->type == TYPE_STDCALL && !(odp->flags & FLAG_PRIVATE))
{
if (!strcmp( odp->name, "DllRegisterServer" ) ||
!strcmp( odp->name, "DllUnregisterServer" ) ||
!strcmp( odp->name, "DllGetClassObject" ) ||
!strcmp( odp->name, "DllCanUnloadNow" ))
{
warning( "Function %s should be marked private\n", odp->name );
}
}
if (!strcmp( odp->name, "@" ) || odp->flags & FLAG_NONAME) if (!strcmp( odp->name, "@" ) || odp->flags & FLAG_NONAME)
{ {
if (ordinal == -1) if (ordinal == -1)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment