dbghelp: Fix handling of BA_OP_ChangeCodeLength (PDB).

This op is heavily used by clang with PDB debug info, while MSVC barely uses it. This fixes a bunch of problems when loading PDB files generated by clang (eg. the PDB files from wine-gecko). Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

dbghelp: Fix handling of BA_OP_ChangeCodeLength (PDB).
de3a8366 · Eric Pouech · Alexandre Julliard · f3e9a1b7 · de3a8366
Commit de3a8366 authored Nov 17, 2022 by Eric Pouech Committed by Alexandre Julliard Nov 17, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

msc.c dlls/dbghelp/msc.c +3 -2

No files found.
--- a/dlls/dbghelp/msc.c
+++ b/dlls/dbghelp/msc.c
@@ -2199,8 +2199,9 @@ static struct symt_function* codeview_create_inline_site(const struct msc_debug_
            inlined->ranges[index++].high = top_func->ranges[0].low + offset;
            break;
        case BA_OP_ChangeCodeLength:
-            /* this op doesn't seem widely used... */
-            inline_site_update_last_range(inlined, index, inlined->ranges[index - 1].low + cvba.arg1);
+            /* this op isn't widely used by MSVC, but clang uses it a lot... */
+            offset += cvba.arg1;
+            inline_site_update_last_range(inlined, index, top_func->ranges[0].low + offset);
            break;
        case BA_OP_ChangeFile:
            chksms = CV_RECORD_GAP(hdr_files, cvba.arg1);