shell32: Fix FindExecutableW() to not check if lpResult after using it. It's…

shell32: Fix FindExecutableW() to not check if lpResult after using it. It's supposed to cause a segfault anyway. Use SE_ERR_FNF rather than a numeric literal.

shell32: Fix FindExecutableW() to not check if lpResult after using it. It's…
df9715b1 · Francois Gouget · Alexandre Julliard · 2538fa31 · df9715b1
Commit df9715b1 authored Dec 13, 2006 by Francois Gouget Committed by Alexandre Julliard Dec 14, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 7 deletions

shlexec.c dlls/shell32/shlexec.c +2 -7

No files found.
--- a/dlls/shell32/shlexec.c
+++ b/dlls/shell32/shlexec.c
@@ -1013,13 +1013,8 @@ HINSTANCE WINAPI FindExecutableW(LPCWSTR lpFile, LPCWSTR lpDirectory, LPWSTR lpR
          (lpFile != NULL ? debugstr_w(lpFile) : "-"), (lpDirectory != NULL ? debugstr_w(lpDirectory) : "-"));
    lpResult[0] = '\0'; /* Start off with an empty return string */
+    if (lpFile == NULL)
-    /* trap NULL parameters on entry */
+	return (HINSTANCE)SE_ERR_FNF;
-    if ((lpFile == NULL) || (lpResult == NULL))
-    {
-        /* FIXME - should throw a warning, perhaps! */
-	return (HINSTANCE)2; /* File not found. Close enough, I guess. */
-    }
    if (lpDirectory)
    {