1. 06 Jul, 2011 1 commit
  2. 30 Jul, 2010 1 commit
  3. 17 May, 2010 1 commit
  4. 10 May, 2010 1 commit
  5. 03 May, 2010 2 commits
  6. 01 Mar, 2010 1 commit
  7. 18 Feb, 2010 1 commit
  8. 28 Sep, 2009 1 commit
    • Dylan Smith's avatar
      richedit: Use ITextHost interface in ME_LinkNotify. · 0342ab0d
      Dylan Smith authored
      Using the ITextHost interface allows this notification to be received
      for windowless richedit controls.  Windowed richedit conrols have an
      ITextHost implementation that will fill in hwndFrom and idFrom, but
      these should probably be initialized to 0 for windowless richedit
      controls.
      0342ab0d
  9. 26 Aug, 2009 1 commit
  10. 17 Aug, 2009 1 commit
  11. 13 Aug, 2009 3 commits
  12. 12 Aug, 2009 4 commits
  13. 10 Aug, 2009 2 commits
    • Dylan Smith's avatar
      richedit: Added missing style releases. · 114a64ce
      Dylan Smith authored
      Style objects are referenced counted in richedit controls, so I tried to
      make sure styles were released properly.  This can be checked using with
      the all_refs global reference count to see if everything is cleaned up.
      114a64ce
    • Dylan Smith's avatar
      richedit: Add closing actions for IRichEditOle_fnInsertObject. · fc618ab0
      Dylan Smith authored
      Previously inserting the object didn't result in the text being wrapped,
      which would cause an assertion error when this is checked for during
      repainting the text.  It is also important to invalidate the affected
      areas of text, update the scrollbar, and end the creation of undo
      transactions for this insertion.
      fc618ab0
  14. 07 Aug, 2009 1 commit
  15. 26 May, 2009 1 commit
  16. 10 Feb, 2009 1 commit
    • Dylan Smith's avatar
      richedit: Store paragraph in cursors. · ecb6c216
      Dylan Smith authored
      This prevents some needless searching for the start of the paragraph
      from a run stored in a cursor.  Usually a pointer to the paragraph is
      already available when the cursor is set anyway.
      ecb6c216
  17. 09 Feb, 2009 4 commits
    • Dylan Smith's avatar
      richedit: Removed ME_StrRelPos, ME_StrRelPos2, & ME_PosToVPos functions. · c8b44555
      Dylan Smith authored
      These functions were just being used for addition, so it was simpler to
      remove the functions and modify the places it was used.
      
      The ME_StrRelPos2 and ME_PosToVPos were just simple wrappers around
      ME_StrRelPos, and ME_PosToVPos wasn't being used.
      c8b44555
    • Dylan Smith's avatar
      richedit: Removed ME_StrLen and ME_StrVLen field access functions. · 5f15de06
      Dylan Smith authored
      These functions were probably previously needed because of some wierd
      special handling of backspace characters, but currently there is no
      reason why the nLen field can't be accessed directly.
      
      Having to functions that just access the string length field just causes
      slightly more effort for someone to look at the code, because they need
      to enter the function to find out what it actually is doing.
      5f15de06
    • Dylan Smith's avatar
      richedit: Removed some conditions that are always taken. · d306b6b5
      Dylan Smith authored
      ME_GetCursorCoordinates had two conditions that were always taken.  The
      first condition was if(pCursor->pRun->type == diRun) was following an
      assertion making the exact same check.  The next one, if(row), should
      always be taken, otherwise the richedit controls are in a corrupt state,
      therefore an assertion is more appropriate.
      d306b6b5
    • Dylan Smith's avatar
      richedit: Directly get start and end of text on Ctrl-Home or Ctrl-End. · 71d797c5
      Dylan Smith authored
      Previously it found the start or end by traversing the linked lists of
      run, rows, paragraphs, and cells from the current position of the
      cursors.  Clearly it is better to get the start or end directly to make
      it a constant time operation.
      71d797c5
  18. 06 Feb, 2009 4 commits
  19. 28 Jan, 2009 1 commit
    • Dylan Smith's avatar
      richedit: Actually store end of line string for end paragraph runs. · 5d74f583
      Dylan Smith authored
      Previously a count of the carraige returns and line feeds were stored
      for end of paragraph runs, and a paragraph sign was stored as the actual
      string.  This was causing many special cases where the length of the
      run needed to be determined differently if the run was or wasn't an
      end of paragraph run.
      
      There wasn't any use for storing the paragraph sign unless some drawing
      code gets commented out to allow the end paragraphs to be shown,
      therefore I changed the code to store the actual string that gets
      retrieved by WM_GETTEXT.
      5d74f583
  20. 27 Jan, 2009 2 commits
    • Dylan Smith's avatar
      richedit: Removed redundant ME_FindItemAtOffset using ME_RunOfsFromCharOfs. · 61308257
      Dylan Smith authored
      The two functions ME_FindItemAtOffset and ME_RunOfsFromCharOfs were almost
      identically used, since ME_FindItemAtOffset was always used to find a run.
      The only difference was how they returned the offset within the run for an
      end of paragraph run.
      
      For ME_FindItemAtOffset it would return the next run if it was in between \r
      and \n. ME_RunOfsFromCharOfs would instead return an nOffset of 0 for end
      paragraph runs.  This subtle difference introduced bugs, so I decided to
      avoid having special case in this function when creating this patch, and
      instead let the caller handle this case.
      61308257
    • Dylan Smith's avatar
      richedit: End of line sequence limited to 2 carriage returns. · 08327374
      Dylan Smith authored
      riched32.dll does preserve the carriage returns and line feeds unlike
      later versions of the richedit control, however the tests previously
      missed the fact that a sequence of carriage returns followed by a line
      feed (e.g. \r\r\r\n) can actually cause multiple paragraph breaks.
      08327374
  21. 21 Jan, 2009 1 commit
    • Dylan Smith's avatar
      richedit: Used ITextHost methods to avoid using window handle directly. · 05c788ac
      Dylan Smith authored
      The methods in ITextHost are mostly thin wrappers around functions that
      take a handle to a window as their first parameter.  This patch just
      uses the wrapper functions provided by ITextHost instead of using the
      functions that require a handle to a window that the editor might now
      have (for windowless richedit controls).
      05c788ac
  22. 16 Jan, 2009 2 commits
  23. 15 Jan, 2009 1 commit
  24. 13 Jan, 2009 1 commit
  25. 18 Dec, 2008 1 commit
    • Dylan Smith's avatar
      richedit: Made sure text is offset by formatting rectangle. · 297716e0
      Dylan Smith authored
      The formatting rectangle is set with EM_SETRECT, and retrieved with
      EM_GETRECT, so it corresponds to rcFormat in the code.  This defines the
      area that the richedit control should draw the text so that it is
      offset by the top-left corner of the formatting rectangle, and clipped
      so that it doesn't draw past the bottom or right hand side.  Thus this
      is important for implementing windowless richedit controls to not
      interfere with the rest of the window.
      297716e0