Commits · b632ddedcd37b28c42e20dc3c7b47df418ba64b8 · wine / wine-cw

22 Mar, 2022 13 commits

server: Actually set initial status in set_async_direct_result handler. · b632dded

authored Mar 20, 2022

Commit 15483b1a (server: Allow calling async_handoff() with status
code STATUS_ALERTED., 2022-02-10) introduced the set_async_direct_result
handler which calls async_set_initial_status().

However, the async_set_initial_status() call does nothing since
async->terminated is set, leaving the async in a confusing state
(unknown_status = 1 but pending/completed).

So far, this issue is unlikely to have been a problem in practice for
the following reasons:

1. async_set_initial_status() would have unset unknown_status, but it
   remains set instead.  This is usually not a problem, since
   unknown_status is usually ever read by code paths effectively
   unreachable for non-device (e.g. socket) asyncs.

   It would still potentially allow set_async_direct_result to be called
   multiple times, but it wouldn't actually happen in practice unless
   something goes wrong.

2. async_set_initial_status() would have set initial_status; however,
   it is left with the default value STATUS_PENDING.  If the actual
   status is something other than that, the handler closes the wait
   handle and async_satisfied (the only real consumer of initial_status)
   would never be called anyway.

For reasons above, this issue is not effectively observable or testable.
Nonetheless, the current code does leave the async object in an
inconsistent state.

Fix this by removing the !async->terminated check in
async_set_initial_status().

Also, remove assert( async->unknown_status ).  The client can now
trigger the assert() by calling set_async_direct_result on a device
async, thereby causing async_set_initial_status() to be called twice.
Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b632dded

ntdll: Use RtlLcidToLocaleName() in the preferred UI language stub. · c3023a12
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
c3023a12
ntdll: Implement RtlLcidToLocaleName(). · a2d44e89
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
a2d44e89
ntdll: Implement RtlIsValidLocaleName(). · ea9a776d
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
ea9a776d
ntdll: Reimplement RtlLocaleNameToLcid() using the locale.nls data. · b631c147
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
b631c147
ntdll: Load the locale.nls file at startup. · 4b0f1163
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
4b0f1163
include: Add some structures for the undocumented locale.nls layout. · f1611958
Alexandre Julliard authored Mar 22, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
f1611958

ws2_32/tests: Test getaddrinfo() for IPv6 DNS querying. · 6bdf3a6b

authored Mar 21, 2022

The tests show that if we don't have a global IPv6 address, getaddrinfo()
will not return IPv6 results. Specifing AF_UNSPEC makes it return IPv4 results.
Signed-off-by: Ziqing Hui <zhui@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6bdf3a6b

ntdll/tests: Enable compilation with long types in path.c. · 01031557

authored Mar 22, 2022

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

01031557

ntdll/tests: Enable compilation with long types in reg.c. · f06f4db4

authored Mar 22, 2022

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f06f4db4

ntdll/tests: Enable compilation with long types in info.c. · 6ab71c6a

authored Mar 22, 2022

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6ab71c6a

ntdll/tests: Enable compilation with long types in port.c. · df94b7b4

authored Mar 22, 2022

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

df94b7b4

ntdll/tests: Enable compilation with long types in pipe.c. · 3a0448f8

authored Mar 22, 2022

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3a0448f8

21 Mar, 2022 27 commits

po: Regenerate po files. · 9e939d14
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
9e939d14

jscript: Don't allow changing prototype on non-extensible objects. · 429325b6

authored Mar 21, 2022

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

429325b6

jscript: Throw error when attempting to set circular __proto__ chains. · 7858f87a

authored Mar 21, 2022

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

7858f87a

jscript: Make Object.prototype.__proto__ an actual accessor. · 364e093a

authored Mar 21, 2022

We have to define it after the constructors are initiated.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

364e093a

jscript: Allow overriding builtin methods by setting the prop. · 94349fdd

authored Mar 21, 2022

Methods can be overriden by simple assignment, not just via defineProperty,
unlike accessors.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

94349fdd

jscript: Return JS_E_INVALID_PROPERTY in jsdisp_call_name if property is not found. · 324b82d9

authored Mar 21, 2022

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

324b82d9

mlang: Skip locales that can't be converted to rfc1766 format. · f324021e
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
f324021e
wow64win: Add missing syscall for NtUserGetClassName(). · 65d0c150
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
65d0c150
wow64win: Add missing syscall for NtUserGetAtomName(). · 90139001
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
90139001

win32u: Move message spy implementation from user32. · 6b3da8a4

authored Mar 21, 2022

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6b3da8a4

user32: Store current spy indent in user_thread_info struct. · 65fe0f65

authored Mar 21, 2022

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

65fe0f65

user.exe: Use win32u directly for cursor icon handle support. · 0b876238

authored Mar 21, 2022

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

0b876238

win32u: Don't use CDECL for window surface functions. · 747f7b54

authored Mar 21, 2022

They are no longer used from PE code.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

747f7b54

win32u: Move dib.drv implementation from gdi.exe. · 39ef9c3a

authored Mar 21, 2022

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

39ef9c3a

winhttp: Avoid freeing potentially uninitialized context in netconn_secure_connect(). · bc4edb8a

authored Mar 21, 2022

Signed-off-by: Paul Gofman <pgofman@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bc4edb8a

kernel32/tests: Add tests for NtInitializeNlsFiles() and RtlGetLocaleFileMappingAddress(). · e195a9b0
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
e195a9b0
ntdll: Implement RtlGetLocaleFileMappingAddress(). · c13d88ba
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
c13d88ba
wow64: Add a wrapper for NtInitializeNlsFiles(). · 4258f982
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
4258f982
ntdll: Implement NtInitializeNlsFiles(). · 5ed078dc
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
5ed078dc
ntdll: Add a helper function to map a section. · cd4fcf9a
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
cd4fcf9a
make_unicode: Generate locale.nls using the Unicode CLDR data. · 8cdb593f
Alexandre Julliard authored Mar 21, 2022
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
8cdb593f
dinput/tests: Add more HID device and extension pointers tests. · c44ba873
Rémi Bernon authored Mar 21, 2022
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
c44ba873

dinput/tests: Introduce a new find_hid_device_path helper. · d470e783

authored Mar 21, 2022

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d470e783

dinput/tests: Remove the HID driver IRP_MJ_POWER handler. · acbfddd3

authored Mar 21, 2022

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

acbfddd3

dinput/tests: Rename HID driver identifiers and files. · f6d2495c

authored Mar 21, 2022

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f6d2495c

dinput/tests: Add more debug traces to the HID driver. · 4c336655

authored Mar 21, 2022

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4c336655

riched20: Set REOBJECT's cp correctly in IRichEditOle::GetObject. · 194ba06c

authored Mar 21, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52705Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

194ba06c