• Alexandros Frantzis's avatar
    msvfw32: Use window name to determine if window is created using MCIWndCreate. · 97e018f9
    Alexandros Frantzis authored
    The current version of the code incorrectly assumes that the lpszClass
    member of CREATESTRUCT passed with WM_CREATE will point to the same
    memory used for the CreateWindowEx class name parameter. MCIWND_Create
    uses this assumption to perform a pointer comparison on the class name
    to determine whether the MCI window is being created using
    MCIWndCreateA/W and should therefore expect a unicode path parameter.
    
    As a side effect of commit e41c255b
    "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the
    CREATESTRUCT lpszClass member started pointing to different memory,
    breaking the current implementation of MCIWND_Create().
    
    This commit fixes the problem by changing MCIWndCreateA/W to use an
    internal window name, unlikely to be used by normal applications, which
    can then be checked in MCIWND_Create to determine if the MCI window is
    being created using MCIWndCreateA/W.
    
    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53578
    97e018f9
Name
Last commit
Last update
dlls Loading commit data...
documentation Loading commit data...
fonts Loading commit data...
include Loading commit data...
libs Loading commit data...
loader Loading commit data...
nls Loading commit data...
po Loading commit data...
programs Loading commit data...
server Loading commit data...
tools Loading commit data...
.editorconfig Loading commit data...
.gitlab-ci.yml Loading commit data...
.mailmap Loading commit data...
ANNOUNCE Loading commit data...
AUTHORS Loading commit data...
COPYING.LIB Loading commit data...
LICENSE Loading commit data...
LICENSE.OLD Loading commit data...
MAINTAINERS Loading commit data...
README Loading commit data...
VERSION Loading commit data...
aclocal.m4 Loading commit data...
configure Loading commit data...
configure.ac Loading commit data...