Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
01feab9e
Commit
01feab9e
authored
Sep 29, 2021
by
Nikolay Sivov
Committed by
Alexandre Julliard
Sep 29, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32/pointermoniker: Fix argument check in GetDisplayName().
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
e12947c0
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
11 deletions
+13
-11
pointermoniker.c
dlls/ole32/pointermoniker.c
+8
-10
moniker.c
dlls/ole32/tests/moniker.c
+5
-1
No files found.
dlls/ole32/pointermoniker.c
View file @
01feab9e
...
...
@@ -380,19 +380,17 @@ static HRESULT WINAPI PointerMonikerImpl_RelativePathTo(IMoniker *iface, IMonike
return
other
?
E_NOTIMPL
:
E_INVALIDARG
;
}
/******************************************************************************
* PointerMoniker_GetDisplayName
******************************************************************************/
static
HRESULT
WINAPI
PointerMonikerImpl_GetDisplayName
(
IMoniker
*
iface
,
IBindCtx
*
pbc
,
IMoniker
*
pmkToLeft
,
LPOLESTR
*
ppszDisplayName
)
static
HRESULT
WINAPI
PointerMonikerImpl_GetDisplayName
(
IMoniker
*
iface
,
IBindCtx
*
pbc
,
IMoniker
*
toleft
,
LPOLESTR
*
name
)
{
TRACE
(
"
(%p,%p,%p,%p)
\n
"
,
iface
,
pbc
,
pmkToLeft
,
ppszDisplayN
ame
);
TRACE
(
"
%p, %p, %p, %p.
\n
"
,
iface
,
pbc
,
toleft
,
n
ame
);
if
(
ppszDisplayName
==
NULL
)
return
E_POINTER
;
if
(
!
name
||
!
pbc
)
{
if
(
name
)
*
name
=
NULL
;
return
E_INVALIDARG
;
}
*
ppszDisplayName
=
NULL
;
return
E_NOTIMPL
;
}
...
...
dlls/ole32/tests/moniker.c
View file @
01feab9e
...
...
@@ -3689,9 +3689,13 @@ todo_wine
hr
=
IMoniker_GetDisplayName
(
moniker
,
bindctx
,
NULL
,
&
display_name
);
ok
(
hr
==
E_NOTIMPL
,
"Unexpected hr %#x.
\n
"
,
hr
);
hr
=
IMoniker_GetDisplayName
(
moniker
,
bindctx
,
NULL
,
NULL
);
ok
(
hr
==
E_INVALIDARG
,
"Unexpected hr %#x.
\n
"
,
hr
);
display_name
=
(
void
*
)
0xdeadbeef
;
hr
=
IMoniker_GetDisplayName
(
moniker
,
NULL
,
NULL
,
&
display_name
);
todo_wine
ok
(
hr
==
E_INVALIDARG
,
"Unexpected hr %#x.
\n
"
,
hr
);
ok
(
!
display_name
,
"Unexpected pointer.
\n
"
);
IBindCtx_Release
(
bindctx
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment