advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be…

advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be checked before "A" (with testcase).

advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be…
0590dc9b · Mikolaj Zalewski · Alexandre Julliard · 8188ce6f · 0590dc9b · 0590dc9b
Commit 0590dc9b authored Sep 27, 2007 by Mikolaj Zalewski Committed by Alexandre Julliard Sep 28, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

security.c dlls/advapi32/security.c +1 -1

security.c dlls/advapi32/tests/security.c +5 -0

No files found.
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -3070,9 +3070,9 @@ static DWORD ParseAclStringFlags(LPCWSTR* StringAcl)
 */
 static const ACEFLAG AceType[] =
 {
-    { SDDL_ACCESS_ALLOWED, ACCESS_ALLOWED_ACE_TYPE },
    { SDDL_ALARM,          SYSTEM_ALARM_ACE_TYPE },
    { SDDL_AUDIT,          SYSTEM_AUDIT_ACE_TYPE },
+    { SDDL_ACCESS_ALLOWED, ACCESS_ALLOWED_ACE_TYPE },
    { SDDL_ACCESS_DENIED,  ACCESS_DENIED_ACE_TYPE },
    /*
    { SDDL_OBJECT_ACCESS_ALLOWED, ACCESS_ALLOWED_OBJECT_ACE_TYPE },

--- a/dlls/advapi32/tests/security.c
+++ b/dlls/advapi32/tests/security.c
@@ -1922,6 +1922,11 @@ static void test_ConvertStringSecurityDescriptor(void)
        "D:(A;;0xFFFFFFFF;;;WD)", SDDL_REVISION_1, &pSD, NULL);
    ok(ret, "ConvertStringSecurityDescriptorToSecurityDescriptor failed with error %d\n", GetLastError());
    LocalFree(pSD);
+    SetLastError(0xdeadbeef);
+    ret = pConvertStringSecurityDescriptorToSecurityDescriptorA(
+        "S:(AU;;0xFFFFFFFF;;;WD)", SDDL_REVISION_1, &pSD, NULL);
+    ok(ret, "ConvertStringSecurityDescriptorToSecurityDescriptor failed with error %d\n", GetLastError());
+    LocalFree(pSD);

    /* test ACE string access right error case */
    SetLastError(0xdeadbeef);