Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
05f319a3
Commit
05f319a3
authored
Jun 08, 2020
by
Zebediah Figura
Committed by
Alexandre Julliard
Jun 09, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
strmbase: Release the allocator in IPin::Disconnect() (Valgrind).
Signed-off-by:
Zebediah Figura
<
z.figura12@gmail.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
7ac949a1
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
2 deletions
+15
-2
videorenderer.c
dlls/quartz/tests/videorenderer.c
+1
-1
vmr9.c
dlls/quartz/tests/vmr9.c
+1
-1
pin.c
dlls/strmbase/pin.c
+13
-0
No files found.
dlls/quartz/tests/videorenderer.c
View file @
05f319a3
...
@@ -1443,7 +1443,7 @@ static void test_connect_pin(void)
...
@@ -1443,7 +1443,7 @@ static void test_connect_pin(void)
ok
(
hr
==
VFW_E_NOT_CONNECTED
,
"Got hr %#x.
\n
"
,
hr
);
ok
(
hr
==
VFW_E_NOT_CONNECTED
,
"Got hr %#x.
\n
"
,
hr
);
ref
=
IMemAllocator_Release
(
allocator
);
ref
=
IMemAllocator_Release
(
allocator
);
todo_wine
ok
(
!
ref
,
"Got outstanding refcount %d.
\n
"
,
ref
);
ok
(
!
ref
,
"Got outstanding refcount %d.
\n
"
,
ref
);
IMemInputPin_Release
(
input
);
IMemInputPin_Release
(
input
);
IPin_Release
(
pin
);
IPin_Release
(
pin
);
ref
=
IFilterGraph2_Release
(
graph
);
ref
=
IFilterGraph2_Release
(
graph
);
...
...
dlls/quartz/tests/vmr9.c
View file @
05f319a3
...
@@ -3072,7 +3072,7 @@ static void test_renderless_formats(void)
...
@@ -3072,7 +3072,7 @@ static void test_renderless_formats(void)
ok
(
hr
==
S_OK
,
"Test %u: Got hr %#x.
\n
"
,
i
,
hr
);
ok
(
hr
==
S_OK
,
"Test %u: Got hr %#x.
\n
"
,
i
,
hr
);
hr
=
IMemInputPin_GetAllocator
(
input
,
&
allocator
);
hr
=
IMemInputPin_GetAllocator
(
input
,
&
allocator
);
todo_wine
_if
(
i
==
0
)
ok
(
hr
==
S_OK
,
"Test %u: Got hr %#x.
\n
"
,
i
,
hr
);
todo_wine
ok
(
hr
==
S_OK
,
"Test %u: Got hr %#x.
\n
"
,
i
,
hr
);
if
(
hr
!=
S_OK
)
if
(
hr
!=
S_OK
)
{
{
test_allocator
(
input
);
test_allocator
(
input
);
...
...
dlls/strmbase/pin.c
View file @
05f319a3
...
@@ -594,6 +594,13 @@ static HRESULT WINAPI source_Disconnect(IPin *iface)
...
@@ -594,6 +594,13 @@ static HRESULT WINAPI source_Disconnect(IPin *iface)
IMemInputPin_Release
(
This
->
pMemInputPin
);
IMemInputPin_Release
(
This
->
pMemInputPin
);
This
->
pMemInputPin
=
NULL
;
This
->
pMemInputPin
=
NULL
;
}
}
if
(
This
->
pAllocator
)
{
IMemAllocator_Release
(
This
->
pAllocator
);
This
->
pAllocator
=
NULL
;
}
if
(
This
->
pin
.
peer
)
if
(
This
->
pin
.
peer
)
{
{
IPin_Release
(
This
->
pin
.
peer
);
IPin_Release
(
This
->
pin
.
peer
);
...
@@ -930,6 +937,12 @@ static HRESULT WINAPI sink_Disconnect(IPin *iface)
...
@@ -930,6 +937,12 @@ static HRESULT WINAPI sink_Disconnect(IPin *iface)
if
(
pin
->
pFuncsTable
->
sink_disconnect
)
if
(
pin
->
pFuncsTable
->
sink_disconnect
)
pin
->
pFuncsTable
->
sink_disconnect
(
pin
);
pin
->
pFuncsTable
->
sink_disconnect
(
pin
);
if
(
pin
->
pAllocator
)
{
IMemAllocator_Release
(
pin
->
pAllocator
);
pin
->
pAllocator
=
NULL
;
}
IPin_Release
(
pin
->
pin
.
peer
);
IPin_Release
(
pin
->
pin
.
peer
);
pin
->
pin
.
peer
=
NULL
;
pin
->
pin
.
peer
=
NULL
;
FreeMediaType
(
&
pin
->
pin
.
mt
);
FreeMediaType
(
&
pin
->
pin
.
mt
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment