mf/tests: Always initialize sample data in create_sample helper.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45988 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47084 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49715 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52183Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mf/tests: Always initialize sample data in create_sample helper.
07cf1313 · Rémi Bernon · Alexandre Julliard · 1d99367e · 07cf1313
Commit 07cf1313 authored Feb 22, 2022 by Rémi Bernon Committed by Alexandre Julliard Feb 23, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 12 deletions

mf.c dlls/mf/tests/mf.c +9 -12

No files found.
--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -5692,18 +5692,15 @@ static IMFSample *create_sample(const BYTE *data, ULONG size)
    ok(hr == S_OK, "MFCreateSample returned %#x\n", hr);
    hr = MFCreateMemoryBuffer(size, &media_buffer);
    ok(hr == S_OK, "MFCreateMemoryBuffer returned %#x\n", hr);
-    if (data)
-    {
-        hr = IMFMediaBuffer_SetCurrentLength(media_buffer, size);
-        ok(hr == S_OK, "SetCurrentLength returned %#x\n", hr);
-        hr = IMFMediaBuffer_Lock(media_buffer, &buffer, NULL, &length);
-        ok(hr == S_OK, "Lock returned %#x\n", hr);
-        ok(length == size, "got size %u\n", length);
-        if (!data) memset(buffer, 0xcd, length);
-        else memcpy(buffer, data, length);
-        hr = IMFMediaBuffer_Unlock(media_buffer);
-        ok(hr == S_OK, "Unlock returned %#x\n", hr);
-    }
+    hr = IMFMediaBuffer_Lock(media_buffer, &buffer, NULL, &length);
+    ok(hr == S_OK, "Lock returned %#x\n", hr);
+    ok(length == 0, "got length %u\n", length);
+    if (!data) memset(buffer, 0xcd, size);
+    else memcpy(buffer, data, size);
+    hr = IMFMediaBuffer_Unlock(media_buffer);
+    ok(hr == S_OK, "Unlock returned %#x\n", hr);
+    hr = IMFMediaBuffer_SetCurrentLength(media_buffer, data ? size : 0);
+    ok(hr == S_OK, "SetCurrentLength returned %#x\n", hr);
    hr = IMFSample_AddBuffer(sample, media_buffer);
    ok(hr == S_OK, "AddBuffer returned %#x\n", hr);
    ret = IMFMediaBuffer_Release(media_buffer);