Potential buffer overflow in PROFILE_CopyEntry.

09a17830 · Francois Gouget · Alexandre Julliard · c6a835a6 · 09a17830
Commit 09a17830 authored May 07, 2001 by Francois Gouget Committed by Alexandre Julliard May 07, 2001
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

profile.c files/profile.c +4 -2

No files found.
--- a/files/profile.c
+++ b/files/profile.c
@@ -120,9 +120,11 @@ static void PROFILE_CopyEntry( char *buffer, const char *value, int len,
            lstrcpynA(env_val, p + 2, min( sizeof(env_val), (int)(p2-p)-1 ));
            if ((env_p = getenv( env_val )) != NULL)
            {
+                int buffer_len;
                lstrcpynA( buffer, env_p, len );
-                buffer += strlen( buffer );
-                len -= strlen( buffer );
+                buffer_len = strlen( buffer );
+                buffer += buffer_len;
+                len -= buffer_len;
            }
            p = p2 + 1;
        }