shell32: Use existing buffer rather than copying, and potentially truncating, a…

shell32: Use existing buffer rather than copying, and potentially truncating, a filename prior to executing it.

shell32: Use existing buffer rather than copying, and potentially truncating, a…
0aad594d · Juan Lang · Alexandre Julliard · 726acf0f · 0aad594d
Commit 0aad594d authored Oct 16, 2011 by Juan Lang Committed by Alexandre Julliard Oct 17, 2011
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

shlexec.c dlls/shell32/shlexec.c +3 -4

No files found.
--- a/dlls/shell32/shlexec.c
+++ b/dlls/shell32/shlexec.c
@@ -1797,6 +1797,7 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc )

 	    /* terminate previous command string after the quote character */
 	    *end = '\0';
+            lpFile = wfileName;
 	}
 	else
 	{
@@ -1827,12 +1828,10 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc )
 		}
 	    }

-           lstrcpynW(wfileName, sei_tmp.lpFile,sizeof(wfileName)/sizeof(WCHAR));
+            lpFile = sei_tmp.lpFile;
 	}
    } else
-       lstrcpynW(wfileName, sei_tmp.lpFile,sizeof(wfileName)/sizeof(WCHAR));
-
-    lpFile = wfileName;
+        lpFile = sei_tmp.lpFile;

    wcmd = wcmdBuffer;
    len = lstrlenW(wszApplicationName) + 1;