winegstreamer: Forbid vaapidecodebin when looking for a specific element.

This will eventually fallback to vaapih264dec and similar decoders if VA-API plugins are indeed available.

winegstreamer: Forbid vaapidecodebin when looking for a specific element.
0c760ef7 · Rémi Bernon · Alexandre Julliard · 4a2cebad · 0c760ef7
Commit 0c760ef7 authored May 17, 2023 by Rémi Bernon Committed by Alexandre Julliard May 29, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 0 deletions

unixlib.c dlls/winegstreamer/unixlib.c +10 -0

No files found.
--- a/dlls/winegstreamer/unixlib.c
+++ b/dlls/winegstreamer/unixlib.c
@@ -101,6 +101,16 @@ GstElement *find_element(GstElementFactoryListType type, GstCaps *src_caps, GstC
    for (tmp = transforms; tmp != NULL && element == NULL; tmp = tmp->next)
    {
        name = gst_plugin_feature_get_name(GST_PLUGIN_FEATURE(tmp->data));
+
+        if (!strcmp(name, "vaapidecodebin"))
+        {
+            /* vaapidecodebin adds asynchronicity which breaks wg_transform synchronous drain / flush
+             * requirements. Ignore it and use VA-API decoders directly instead.
+             */
+            GST_WARNING("Ignoring vaapidecodebin decoder.");
+            continue;
+        }
+
        if (!(element = gst_element_factory_create(GST_ELEMENT_FACTORY(tmp->data), NULL)))
            GST_WARNING("Failed to create %s element.", name);
    }