Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
0c989fb0
Commit
0c989fb0
authored
Oct 09, 2012
by
Francois Gouget
Committed by
Alexandre Julliard
Oct 09, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32: Don't expand environment variables in ShellExecute()'s parameters argument.
parent
40b01c1b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
18 deletions
+1
-18
shlexec.c
dlls/shell32/shlexec.c
+0
-17
shlexec.c
dlls/shell32/tests/shlexec.c
+1
-1
No files found.
dlls/shell32/shlexec.c
View file @
0c989fb0
...
...
@@ -1740,23 +1740,6 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc )
sei_tmp
.
lpFile
=
wszApplicationName
;
}
if
(
*
sei_tmp
.
lpParameters
)
{
len
=
ExpandEnvironmentStringsW
(
sei_tmp
.
lpParameters
,
NULL
,
0
);
if
(
len
>
0
)
{
LPWSTR
buf
;
len
++
;
buf
=
HeapAlloc
(
GetProcessHeap
(),
0
,
len
*
sizeof
(
WCHAR
));
ExpandEnvironmentStringsW
(
sei_tmp
.
lpParameters
,
buf
,
len
);
if
(
wszParameters
!=
parametersBuffer
)
HeapFree
(
GetProcessHeap
(),
0
,
wszParameters
);
wszParameters
=
buf
;
parametersLen
=
len
;
sei_tmp
.
lpParameters
=
wszParameters
;
}
}
if
(
*
sei_tmp
.
lpDirectory
)
{
len
=
ExpandEnvironmentStringsW
(
sei_tmp
.
lpDirectory
,
NULL
,
0
);
...
...
dlls/shell32/tests/shlexec.c
View file @
0c989fb0
...
...
@@ -1354,7 +1354,7 @@ static const argify_tests_t argify_tests[] =
{
""
,
"
\"
p
\\
three pfour
\"
"
,
"pfive"
,
""
,
NULL
},
0
}},
/* Environment variables are left untouched. */
{
"Params23456"
,
"%TMPDIR% %t %c"
,
0
x12
,
{
"Params23456"
,
"%TMPDIR% %t %c"
,
0
,
{
"
\"
%TMPDIR%
\"
\"
%t
\"
\"
%c
\"
\"\"
\"\"
"
,
{
""
,
"%TMPDIR%"
,
"%t"
,
"%c"
,
""
,
""
,
NULL
},
0
}},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment