msvcrt: Free previous environment variable when clearing.

Shifting the rest of the variables by one towards indices of lesser value overwrites the variable being cleared and effectively leaks it. Signed-off-by: David Kahurani <k.kahurani@gmail.com>

msvcrt: Free previous environment variable when clearing.
1580c113 · David Kahurani · Alexandre Julliard · 9164cf8f · 1580c113
Commit 1580c113 authored Jan 26, 2024 by David Kahurani Committed by Alexandre Julliard Jan 29, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

environ.c dlls/msvcrt/environ.c +2 -0

No files found.
--- a/dlls/msvcrt/environ.c
+++ b/dlls/msvcrt/environ.c
@@ -161,6 +161,7 @@ static int env_set(char **env, wchar_t **wenv)
    *eq = '=';
    if (!eq[1])
    {
+        free(MSVCRT__environ[idx]);
        for(; MSVCRT__environ[idx]; idx++)
            MSVCRT__environ[idx] = MSVCRT__environ[idx + 1];
    }
@@ -187,6 +188,7 @@ static int env_set(char **env, wchar_t **wenv)
    *weq = '=';
    if (!weq[1])
    {
+        free(MSVCRT__wenviron[idx]);
        for(; MSVCRT__wenviron[idx]; idx++)
            MSVCRT__wenviron[idx] = MSVCRT__wenviron[idx + 1];
    }