Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
15ccfef0
Commit
15ccfef0
authored
May 04, 2014
by
Zhenbo Li
Committed by
Alexandre Julliard
May 08, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Added IHTMLSelectElement::remove method implementation.
parent
b8aecb92
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
27 additions
and
2 deletions
+27
-2
htmlselect.c
dlls/mshtml/htmlselect.c
+8
-2
dom.c
dlls/mshtml/tests/dom.c
+19
-0
No files found.
dlls/mshtml/htmlselect.c
View file @
15ccfef0
...
...
@@ -407,8 +407,14 @@ static HRESULT WINAPI HTMLSelectElement_add(IHTMLSelectElement *iface, IHTMLElem
static
HRESULT
WINAPI
HTMLSelectElement_remove
(
IHTMLSelectElement
*
iface
,
LONG
index
)
{
HTMLSelectElement
*
This
=
impl_from_IHTMLSelectElement
(
iface
);
FIXME
(
"(%p)->(%d)
\n
"
,
This
,
index
);
return
E_NOTIMPL
;
nsresult
nsres
;
TRACE
(
"(%p)->(%d)
\n
"
,
This
,
index
);
nsres
=
nsIDOMHTMLSelectElement_select_Remove
(
This
->
nsselect
,
index
);
if
(
NS_FAILED
(
nsres
))
{
ERR
(
"Remove failed: %08x
\n
"
,
nsres
);
return
E_FAIL
;
}
return
S_OK
;
}
static
HRESULT
WINAPI
HTMLSelectElement_put_length
(
IHTMLSelectElement
*
iface
,
LONG
v
)
...
...
dlls/mshtml/tests/dom.c
View file @
15ccfef0
...
...
@@ -2559,6 +2559,24 @@ static void _test_select_get_disabled(unsigned line, IHTMLSelectElement *select,
_test_elem3_get_disabled
(
line
,
(
IUnknown
*
)
select
,
exb
);
}
static
void
test_select_remove
(
IHTMLSelectElement
*
select
)
{
HRESULT
hres
;
hres
=
IHTMLSelectElement_remove
(
select
,
3
);
ok
(
hres
==
S_OK
,
"remove failed: %08x, expected S_OK
\n
"
,
hres
);
test_select_length
(
select
,
2
);
hres
=
IHTMLSelectElement_remove
(
select
,
-
1
);
todo_wine
ok
(
hres
==
E_INVALIDARG
,
"remove failed: %08x, expected E_INVALIDARG
\n
"
,
hres
);
test_select_length
(
select
,
2
);
hres
=
IHTMLSelectElement_remove
(
select
,
0
);
ok
(
hres
==
S_OK
,
"remove failed:%08x
\n
"
,
hres
);
test_select_length
(
select
,
1
);
}
#define test_text_length(u,l) _test_text_length(__LINE__,u,l)
static
void
_test_text_length
(
unsigned
line
,
IUnknown
*
unk
,
LONG
l
)
{
...
...
@@ -4324,6 +4342,7 @@ static void test_select_elem(IHTMLSelectElement *select)
test_select_multiple
(
select
,
VARIANT_FALSE
);
test_select_set_multiple
(
select
,
VARIANT_TRUE
);
test_select_remove
(
select
);
}
static
void
test_form_item
(
IHTMLElement
*
elem
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment