ntdll: Prevent double free (Coverity).

The fd gets overwritten, therefore we need to close it before doing so. Signed-off-by: Fabian Maurer <dark.shadow4@web.de>

ntdll: Prevent double free (Coverity).
173ffe50 · Fabian Maurer · Alexandre Julliard · c7b8da64 · 173ffe50
Commit 173ffe50 authored May 16, 2022 by Fabian Maurer Committed by Alexandre Julliard Oct 17, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

file.c dlls/ntdll/unix/file.c +1 -1

No files found.
--- a/dlls/ntdll/unix/file.c
+++ b/dlls/ntdll/unix/file.c
@@ -4417,12 +4417,12 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE handle, IO_STATUS_BLOCK *io,
                if (size > 0x10000) size = 0x10000;
                if ((tmpbuf = malloc( size )))
                {
+                    if (needs_close) close( fd );
                    if (!server_get_unix_fd( handle, FILE_READ_DATA, &fd, &needs_close, NULL, NULL ))
                    {
                        int res = recv( fd, tmpbuf, size, MSG_PEEK );
                        info->MessagesAvailable = (res > 0);
                        info->NextMessageSize = (res >= 0) ? res : MAILSLOT_NO_MESSAGE;
-                        if (needs_close) close( fd );
                    }
                    free( tmpbuf );
                }