rpcrt4: Use MustFree for all non-base types in get_param_pointer_info.

Fixes a leak for VT_VARIANT. Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

rpcrt4: Use MustFree for all non-base types in get_param_pointer_info.
1980fcaf · Jacek Caban · Alexandre Julliard · d26998d6 · 1980fcaf
Commit 1980fcaf authored Jan 30, 2020 by Jacek Caban Committed by Alexandre Julliard Jan 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 6 deletions

ndr_typelib.c dlls/rpcrt4/ndr_typelib.c +2 -6

No files found.
--- a/dlls/rpcrt4/ndr_typelib.c
+++ b/dlls/rpcrt4/ndr_typelib.c
@@ -925,12 +925,6 @@ static HRESULT get_param_pointer_info(ITypeInfo *typeinfo, TYPEDESC *tdesc, int 
        ITypeInfo_ReleaseTypeAttr(refinfo, attr);
        ITypeInfo_Release(refinfo);
        break;
-    case VT_BSTR:
-        *flags |= IsSimpleRef | MustFree;
-        *tfs_tdesc = tdesc;
-        if (!is_in && is_out)
-            *server_size = sizeof(void *);
-        break;
    default:
        *flags |= IsSimpleRef;
        *tfs_tdesc = tdesc;
@@ -938,6 +932,8 @@ static HRESULT get_param_pointer_info(ITypeInfo *typeinfo, TYPEDESC *tdesc, int 
            *server_size = type_memsize(typeinfo, tdesc);
        if ((*basetype = get_basetype(typeinfo, tdesc)))
            *flags |= IsBasetype;
+        else
+            *flags |= MustFree;
        break;
    }