msi: Fix a record leak on error path (Coverity).

203d282a · Nikolay Sivov · Alexandre Julliard · c01c0b52 · 203d282a
Commit 203d282a authored Mar 27, 2014 by Nikolay Sivov Committed by Alexandre Julliard Mar 27, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

table.c dlls/msi/table.c +3 -0

No files found.
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -2092,7 +2092,10 @@ static UINT TABLE_drop(struct tagMSIVIEW *view)

    r = TABLE_CreateView(tv->db, szTables, &tables);
    if (r != ERROR_SUCCESS)
+    {
+        msiobj_release(&rec->hdr);
        return r;
+    }

    r = msi_table_find_row((MSITABLEVIEW *)tables, rec, &row, NULL);
    if (r != ERROR_SUCCESS)