msxml3: Fix double-free of BSTR in domdoc tests.

Using the _bstr_ allocator adds the returned string to a cache, so the string shouldn't be freed with SysFreeString. Therefore, just replace the lone call to _bstr_ in this function by a straight call to SysAllocString.

msxml3: Fix double-free of BSTR in domdoc tests.
211e4fc0 · Rob Shearman · Alexandre Julliard · b84201dc · 211e4fc0
Commit 211e4fc0 authored Dec 02, 2009 by Rob Shearman Committed by Alexandre Julliard Dec 02, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

domdoc.c dlls/msxml3/tests/domdoc.c +4 -1

No files found.
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -209,6 +209,9 @@ static const CHAR szBasicTransformOutput[] =
 static const WCHAR szNonExistentFile[] = {
    'c', ':', '\\', 'N', 'o', 'n', 'e', 'x', 'i', 's', 't', 'e', 'n', 't', '.', 'x', 'm', 'l', 0
 };
+static const WCHAR szNonExistentAttribute[] = {
+    'n','o','n','E','x','i','s','i','t','i','n','g','A','t','t','r','i','b','u','t','e',0
+};
 static const WCHAR szDocument[] = {
    '#', 'd', 'o', 'c', 'u', 'm', 'e', 'n', 't', 0
 };
@@ -1110,7 +1113,7 @@ static void test_domnode( void )
        SysFreeString( str );

        attr = (IXMLDOMAttribute*)0xdeadbeef;
-        str = _bstr_("nonExisitingAttribute");
+        str = SysAllocString( szNonExistentAttribute );
        r = IXMLDOMElement_getAttributeNode( element, str, &attr);
        ok( r == S_FALSE, "getAttributeNode ret %08x\n", r );
        ok( attr == NULL, "getAttributeNode ret %p, expected NULL\n", attr );