Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
259b5fdf
Commit
259b5fdf
authored
Sep 29, 2010
by
Hans Leidekker
Committed by
Alexandre Julliard
Sep 29, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Treat empty string as NULL in MsiGetSummaryInformationW.
parent
2b2fa04c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
2 deletions
+13
-2
suminfo.c
dlls/msi/suminfo.c
+1
-1
suminfo.c
dlls/msi/tests/suminfo.c
+12
-1
No files found.
dlls/msi/suminfo.c
View file @
259b5fdf
...
@@ -469,7 +469,7 @@ UINT WINAPI MsiGetSummaryInformationW( MSIHANDLE hDatabase,
...
@@ -469,7 +469,7 @@ UINT WINAPI MsiGetSummaryInformationW( MSIHANDLE hDatabase,
if
(
!
pHandle
)
if
(
!
pHandle
)
return
ERROR_INVALID_PARAMETER
;
return
ERROR_INVALID_PARAMETER
;
if
(
szDatabase
)
if
(
szDatabase
&&
szDatabase
[
0
]
)
{
{
LPCWSTR
persist
=
uiUpdateCount
?
MSIDBOPEN_TRANSACT
:
MSIDBOPEN_READONLY
;
LPCWSTR
persist
=
uiUpdateCount
?
MSIDBOPEN_TRANSACT
:
MSIDBOPEN_READONLY
;
...
...
dlls/msi/tests/suminfo.c
View file @
259b5fdf
...
@@ -86,7 +86,18 @@ static void test_suminfo(void)
...
@@ -86,7 +86,18 @@ static void test_suminfo(void)
ok
(
r
==
ERROR_INVALID_PARAMETER
,
"MsiGetSummaryInformation wrong error
\n
"
);
ok
(
r
==
ERROR_INVALID_PARAMETER
,
"MsiGetSummaryInformation wrong error
\n
"
);
r
=
MsiGetSummaryInformation
(
hdb
,
NULL
,
0
,
&
hsuminfo
);
r
=
MsiGetSummaryInformation
(
hdb
,
NULL
,
0
,
&
hsuminfo
);
ok
(
r
==
ERROR_SUCCESS
,
"MsiGetSummaryInformation failed
\n
"
);
ok
(
r
==
ERROR_SUCCESS
,
"MsiGetSummaryInformation failed %u
\n
"
,
r
);
r
=
MsiCloseHandle
(
hsuminfo
);
ok
(
r
==
ERROR_SUCCESS
,
"MsiCloseHandle failed
\n
"
);
r
=
MsiGetSummaryInformation
(
0
,
""
,
0
,
&
hsuminfo
);
todo_wine
ok
(
r
==
ERROR_INSTALL_PACKAGE_INVALID
||
r
==
ERROR_INSTALL_PACKAGE_OPEN_FAILED
,
"MsiGetSummaryInformation failed %u
\n
"
,
r
);
r
=
MsiGetSummaryInformation
(
hdb
,
""
,
0
,
&
hsuminfo
);
ok
(
r
==
ERROR_SUCCESS
,
"MsiGetSummaryInformation failed %u
\n
"
,
r
);
r
=
MsiSummaryInfoGetPropertyCount
(
0
,
NULL
);
r
=
MsiSummaryInfoGetPropertyCount
(
0
,
NULL
);
ok
(
r
==
ERROR_INVALID_HANDLE
,
"getpropcount failed
\n
"
);
ok
(
r
==
ERROR_INVALID_HANDLE
,
"getpropcount failed
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment