ws2_32/tests: Continue sending remaining data on short write in test_write_events.

Today, we assert that a short write clears the FD_WRITE event bit; however, short writes can never happen on Windows in the first place. We're testing for a property of a socket behaviour that does not exist on Windows, but currently happens to be exhibited by Wine. Ignore short writes, and continue sending until it fails with EWOULDBLOCK. This way, the test won't care whether or not a short write clears FD_WRITE. This allows us some flexibility in implementation of send(). Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ws2_32/tests: Continue sending remaining data on short write in test_write_events.
29883e2d · Jinoh Kang · Alexandre Julliard · d162a3e2 · 29883e2d
Commit 29883e2d authored Mar 20, 2022 by Jinoh Kang Committed by Alexandre Julliard Mar 22, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

sock.c dlls/ws2_32/tests/sock.c +3 -6

No files found.
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -5666,14 +5666,11 @@ static void test_write_events(struct event_test_ctx *ctx)

    if (!broken(1))
    {
-        while ((ret = send(server, buffer, buffer_size, 0)) == buffer_size);
        /* Windows will never send less than buffer_size bytes here, but Linux
         * may do a short write. */
-        todo_wine_if (ret > 0)
-        {
-            ok(ret == -1, "got %d\n", ret);
-            ok(WSAGetLastError() == WSAEWOULDBLOCK, "got error %u\n", WSAGetLastError());
-        }
+        while ((ret = send(server, buffer, buffer_size, 0)) > 0);
+        ok(ret == -1, "got %d\n", ret);
+        ok(WSAGetLastError() == WSAEWOULDBLOCK, "got error %u\n", WSAGetLastError());

        while (recv(client, buffer, buffer_size, 0) > 0);
        ok(WSAGetLastError() == WSAEWOULDBLOCK, "got error %u\n", WSAGetLastError());