d3dx9: Validate state operation in d3dx_parse_state().

Signed-off-by: Paul Gofman <gofmanp@gmail.com> Signed-off-by: Matteo Bruni <mbruni@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d3dx9: Validate state operation in d3dx_parse_state().
2b5b069d · Paul Gofman · Alexandre Julliard · f925becd · 2b5b069d
Commit 2b5b069d authored Mar 24, 2020 by Paul Gofman Committed by Alexandre Julliard Mar 25, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

effect.c dlls/d3dx9_36/effect.c +6 -0

No files found.
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -5564,6 +5564,12 @@ static HRESULT d3dx_parse_state(struct d3dx_effect *effect, struct d3dx_state *s
    state->type = ST_CONSTANT;

    read_dword(ptr, &state->operation);
+    if (state->operation >= ARRAY_SIZE(state_table))
+    {
+        WARN("Unknown state operation %u.\n", state->operation);
+        return D3DERR_INVALIDCALL;
+    }
+
    TRACE("Operation: %#x (%s)\n", state->operation, state_table[state->operation].name);

    read_dword(ptr, &state->index);