dinput: Hold the HID joystick CS when updating the device state.

The read buffer is only used by the reading thread but the device state is not, we should only update it while holding the CS. Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dinput: Hold the HID joystick CS when updating the device state.
2b61d8dd · Rémi Bernon · Alexandre Julliard · 1014cfcf · 2b61d8dd
Commit 2b61d8dd authored Oct 08, 2021 by Rémi Bernon Committed by Alexandre Julliard Oct 08, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

joystick_hid.c dlls/dinput/joystick_hid.c +2 -0

No files found.
--- a/dlls/dinput/joystick_hid.c
+++ b/dlls/dinput/joystick_hid.c
@@ -1603,6 +1603,7 @@ static HRESULT hid_joystick_read_state( IDirectInputDevice8W *iface )
        }
    }

+    EnterCriticalSection( &impl->base.crit );
    do
    {
        count = impl->usages_count;
@@ -1638,6 +1639,7 @@ static HRESULT hid_joystick_read_state( IDirectInputDevice8W *iface )
        memset( &impl->read_ovl, 0, sizeof(impl->read_ovl) );
        impl->read_ovl.hEvent = impl->base.read_event;
    } while (ReadFile( impl->device, report_buf, report_len, &count, &impl->read_ovl ));
+    LeaveCriticalSection( &impl->base.crit );

    return DI_OK;
 }