Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
2d801c46
Commit
2d801c46
authored
Mar 28, 2024
by
Alexandre Julliard
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
rpcrt4: Return the correct failure for a NULL binding handle.
Fixes a test crash in interpreted mode.
parent
a2c20d0e
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
5 deletions
+2
-5
ndr_stubless.c
dlls/rpcrt4/ndr_stubless.c
+1
-4
rpc_message.c
dlls/rpcrt4/rpc_message.c
+1
-1
No files found.
dlls/rpcrt4/ndr_stubless.c
View file @
2d801c46
...
@@ -346,9 +346,9 @@ static handle_t client_get_handle(const MIDL_STUB_MESSAGE *pStubMsg,
...
@@ -346,9 +346,9 @@ static handle_t client_get_handle(const MIDL_STUB_MESSAGE *pStubMsg,
{
{
ERR
(
"null context handle isn't allowed
\n
"
);
ERR
(
"null context handle isn't allowed
\n
"
);
RpcRaiseException
(
RPC_X_SS_IN_NULL_CONTEXT
);
RpcRaiseException
(
RPC_X_SS_IN_NULL_CONTEXT
);
return
NULL
;
}
}
/* FIXME: should we store this structure in stubMsg.pContext? */
/* FIXME: should we store this structure in stubMsg.pContext? */
return
NULL
;
}
}
default:
default:
ERR
(
"bad explicit binding handle type (0x%02x)
\n
"
,
pProcHeader
->
handle_type
);
ERR
(
"bad explicit binding handle type (0x%02x)
\n
"
,
pProcHeader
->
handle_type
);
...
@@ -745,10 +745,7 @@ static LONG_PTR do_ndr_client_call( const MIDL_STUB_DESC *stub_desc, const PFORM
...
@@ -745,10 +745,7 @@ static LONG_PTR do_ndr_client_call( const MIDL_STUB_DESC *stub_desc, const PFORM
/* we only need a handle if this isn't an object method */
/* we only need a handle if this isn't an object method */
if
(
!
(
proc_header
->
Oi_flags
&
Oi_OBJECT_PROC
))
if
(
!
(
proc_header
->
Oi_flags
&
Oi_OBJECT_PROC
))
{
hbinding
=
client_get_handle
(
stub_msg
,
proc_header
,
handle_format
);
hbinding
=
client_get_handle
(
stub_msg
,
proc_header
,
handle_format
);
if
(
!
hbinding
)
return
0
;
}
stub_msg
->
BufferLength
=
0
;
stub_msg
->
BufferLength
=
0
;
...
...
dlls/rpcrt4/rpc_message.c
View file @
2d801c46
...
@@ -1638,7 +1638,7 @@ RPC_STATUS WINAPI I_RpcGetBuffer(PRPC_MESSAGE pMsg)
...
@@ -1638,7 +1638,7 @@ RPC_STATUS WINAPI I_RpcGetBuffer(PRPC_MESSAGE pMsg)
if
(
!
bind
)
if
(
!
bind
)
{
{
ERR
(
"no binding
\n
"
);
WARN
(
"no binding
\n
"
);
return
RPC_S_INVALID_BINDING
;
return
RPC_S_INVALID_BINDING
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment