winemenubuilder: Avoid double free (Coverity).

Signed-off-by: Marcus Meissner <marcus@jet.franken.de> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winemenubuilder: Avoid double free (Coverity).
2e32c0c6 · Marcus Meissner · Alexandre Julliard · e7a56825 · 2e32c0c6
Commit 2e32c0c6 authored Aug 21, 2016 by Marcus Meissner Committed by Alexandre Julliard Aug 22, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 7 deletions

winemenubuilder.c programs/winemenubuilder/winemenubuilder.c +2 -7

No files found.
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -1005,13 +1005,8 @@ static HRESULT write_native_icon(IStream *iconStream, ICONDIRENTRY *pIconDirEntr

    position.QuadPart = 0;
    hr = IStream_Seek(iconStream, position, STREAM_SEEK_SET, NULL);
-    if (FAILED(hr))
-        goto end;
-    hr = convert_to_native_icon(iconStream, &nIndex, 1, &CLSID_WICPngEncoder, icon_name, szFileName);
-
-end:
-    HeapFree(GetProcessHeap(), 0, pIconDirEntry);
-    return hr;
+    if (FAILED(hr)) return hr;
+    return convert_to_native_icon(iconStream, &nIndex, 1, &CLSID_WICPngEncoder, icon_name, szFileName);
 }

 static WCHAR* assoc_query(ASSOCSTR assocStr, LPCWSTR name, LPCWSTR extra)