msi: Avoid accessing uninitialized memory in ACTION_AppSearchReg.

Found by valgrind.

msi: Avoid accessing uninitialized memory in ACTION_AppSearchReg.
2eb33f5b · Hans Leidekker · Alexandre Julliard · 3f70b078 · 2eb33f5b
Commit 2eb33f5b authored Oct 27, 2009 by Hans Leidekker Committed by Alexandre Julliard Oct 27, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

appsearch.c dlls/msi/appsearch.c +2 -1

No files found.
--- a/dlls/msi/appsearch.c
+++ b/dlls/msi/appsearch.c
@@ -445,7 +445,8 @@ static UINT ACTION_AppSearchReg(MSIPACKAGE *package, LPWSTR *appValue, MSISIGNAT
    if (sz == 0)
        goto end;

-    if ((ptr = strchrW((LPWSTR)value, '"')) && (end = strchrW(++ptr, '"')))
+    if ((regType == REG_SZ || regType == REG_EXPAND_SZ) &&
+        (ptr = strchrW((LPWSTR)value, '"')) && (end = strchrW(++ptr, '"')))
        *end = '\0';
    else
        ptr = (LPWSTR)value;