msxml3: Don't leak node in xmldoc_createElement in the wrong type was specified.

306129c9 · Rob Shearman · Alexandre Julliard · 76d0cab1 · 306129c9
Commit 306129c9 authored Nov 14, 2007 by Rob Shearman Committed by Alexandre Julliard Nov 15, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

xmldoc.c dlls/msxml3/xmldoc.c +1 -2

No files found.
--- a/dlls/msxml3/xmldoc.c
+++ b/dlls/msxml3/xmldoc.c
@@ -449,11 +449,10 @@ static HRESULT WINAPI xmldoc_createElement(IXMLDocument *iface, VARIANT vType,

    *ppElem = NULL;

-    node = xmlNewNode(NULL, empty);
-
    if (V_VT(&vType) != VT_I4)
        return E_INVALIDARG;

+    node = xmlNewNode(NULL, empty);
    node->type = type_msxml_to_libxml(V_I4(&vType));

    /* FIXME: create xmlNodePtr based on vType and var1 */