msvcrt: Don't write past buffer in strftime.

Signed-off-by: Piotr Caban <piotr@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msvcrt: Don't write past buffer in strftime.
30913ff5 · Piotr Caban · Alexandre Julliard · b22236d1 · 30913ff5
Commit 30913ff5 authored Sep 30, 2019 by Piotr Caban Committed by Alexandre Julliard Sep 30, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

time.c dlls/msvcrt/time.c +4 -2

No files found.
--- a/dlls/msvcrt/time.c
+++ b/dlls/msvcrt/time.c
@@ -1197,10 +1197,12 @@ static MSVCRT_size_t strftime_helper(char *str, MSVCRT_size_t max, const char *f
        case 'T':
            if(!strftime_int(str, &ret, max, mstm->tm_hour, alternate ? 0 : 2, 0, 23))
                return 0;
-            str[ret++] = ':';
+            if(ret < max)
+                str[ret++] = ':';
            if(!strftime_int(str, &ret, max, mstm->tm_min, alternate ? 0 : 2, 0, 59))
                return 0;
-            str[ret++] = ':';
+            if(ret < max)
+                str[ret++] = ':';
            if(!strftime_int(str, &ret, max, mstm->tm_sec, alternate ? 0 : 2, 0, 59))
                return 0;
            break;