Skip to content

W
wine-winehq
Commit 30cc2119 authored by Rob Shearman's avatar Rob Shearman Committed by Alexandre Julliard
Browse files
Options

ole32: Remove spurious AddRef of returned object on retrieval of an interface…

ole32: Remove spurious AddRef of returned object on retrieval of an interface from the global interface table.
parent 7d90b6ce
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 5 deletions
dlls/ole32/git.c
View file @ 30cc2119
...@@ -262,7 +262,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal( ...@@ -262,7 +262,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
{ {
StdGITEntry* entry; StdGITEntry* entry;
HRESULT hres; HRESULT hres;
LPUNKNOWN lpUnk;
IStream *stream; IStream *stream;
TRACE("dwCookie=0x%x, riid=%s, ppv=%p\n", dwCookie, debugstr_guid(riid), ppv); TRACE("dwCookie=0x%x, riid=%s, ppv=%p\n", dwCookie, debugstr_guid(riid), ppv);
...@@ -296,9 +295,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal( ...@@ -296,9 +295,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
return hres; return hres;
} }
/* addref it */
lpUnk = *ppv;
IUnknown_AddRef(lpUnk);
TRACE("ppv=%p\n", *ppv); TRACE("ppv=%p\n", *ppv);
return S_OK; return S_OK;
} }
......
dlls/ole32/tests/marshal.c
View file @ 30cc2119
...@@ -2651,7 +2651,6 @@ static void test_globalinterfacetable(void) ...@@ -2651,7 +2651,6 @@ static void test_globalinterfacetable(void)
hr = IGlobalInterfaceTable_RevokeInterfaceFromGlobal(git, cookie); hr = IGlobalInterfaceTable_RevokeInterfaceFromGlobal(git, cookie);
ok_ole_success(hr, IGlobalInterfaceTable_RevokeInterfaceFromGlobal); ok_ole_success(hr, IGlobalInterfaceTable_RevokeInterfaceFromGlobal);
todo_wine
ok_no_locks(); ok_no_locks();
IGlobalInterfaceTable_Release(git); IGlobalInterfaceTable_Release(git);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment