Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
315cf3b6
Commit
315cf3b6
authored
Nov 17, 2020
by
Nikolay Sivov
Committed by
Alexandre Julliard
Nov 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
evr/mixer: Improve GetService() handling of unsupported interfaces/services.
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
8e82c720
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
mixer.c
dlls/evr/mixer.c
+3
-1
evr.c
dlls/evr/tests/evr.c
+4
-0
No files found.
dlls/evr/mixer.c
View file @
315cf3b6
...
...
@@ -1650,11 +1650,13 @@ static HRESULT WINAPI video_mixer_getservice_GetService(IMFGetService *iface, RE
{
return
IMFGetService_QueryInterface
(
iface
,
riid
,
obj
);
}
return
E_NOINTERFACE
;
}
FIXME
(
"Unsupported service %s, riid %s.
\n
"
,
debugstr_guid
(
service
),
debugstr_guid
(
riid
));
return
E_NOTIMPL
;
return
MF_E_UNSUPPORTED_SERVICE
;
}
static
const
IMFGetServiceVtbl
video_mixer_getservice_vtbl
=
...
...
dlls/evr/tests/evr.c
View file @
315cf3b6
...
...
@@ -489,6 +489,10 @@ static void test_default_mixer(void)
check_service_interface
(
transform
,
&
MR_VIDEO_MIXER_SERVICE
,
&
IID_IMFVideoProcessor
,
TRUE
);
check_service_interface
(
transform
,
&
MR_VIDEO_MIXER_SERVICE
,
&
IID_IMFVideoMixerControl
,
TRUE
);
check_service_interface
(
transform
,
&
MR_VIDEO_MIXER_SERVICE
,
&
IID_IMFVideoPositionMapper
,
TRUE
);
check_service_interface
(
transform
,
&
MR_VIDEO_MIXER_SERVICE
,
&
IID_IMFTransform
,
FALSE
);
hr
=
MFGetService
((
IUnknown
*
)
transform
,
&
MR_VIDEO_RENDER_SERVICE
,
&
IID_IUnknown
,
(
void
**
)
&
unk
);
ok
(
hr
==
MF_E_UNSUPPORTED_SERVICE
,
"Unexpected hr %#x.
\n
"
,
hr
);
if
(
SUCCEEDED
(
MFGetService
((
IUnknown
*
)
transform
,
&
MR_VIDEO_MIXER_SERVICE
,
&
IID_IMFVideoMixerControl2
,
(
void
**
)
&
mixer_control2
)))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment