Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
33aa647e
Commit
33aa647e
authored
Mar 13, 2013
by
Alexandre Julliard
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Avoid intermediate variables when calling create_record.
parent
c0e85b9f
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
11 deletions
+2
-11
automation.c
dlls/msi/automation.c
+2
-11
No files found.
dlls/msi/automation.c
View file @
33aa647e
...
@@ -1203,11 +1203,7 @@ static HRESULT view_invoke(
...
@@ -1203,11 +1203,7 @@ static HRESULT view_invoke(
V_VT
(
pVarResult
)
=
VT_DISPATCH
;
V_VT
(
pVarResult
)
=
VT_DISPATCH
;
if
((
ret
=
MsiViewFetch
(
This
->
msiHandle
,
&
msiHandle
))
==
ERROR_SUCCESS
)
if
((
ret
=
MsiViewFetch
(
This
->
msiHandle
,
&
msiHandle
))
==
ERROR_SUCCESS
)
{
{
IDispatch
*
dispatch
=
NULL
;
if
(
FAILED
(
hr
=
create_record
(
msiHandle
,
&
V_DISPATCH
(
pVarResult
))))
if
(
SUCCEEDED
(
hr
=
create_record
(
msiHandle
,
&
dispatch
)))
V_DISPATCH
(
pVarResult
)
=
dispatch
;
else
ERR
(
"Failed to create Record object, hresult 0x%08x
\n
"
,
hr
);
ERR
(
"Failed to create Record object, hresult 0x%08x
\n
"
,
hr
);
}
}
else
if
(
ret
==
ERROR_NO_MORE_ITEMS
)
else
if
(
ret
==
ERROR_NO_MORE_ITEMS
)
...
@@ -1684,7 +1680,6 @@ static HRESULT InstallerImpl_CreateRecord(WORD wFlags,
...
@@ -1684,7 +1680,6 @@ static HRESULT InstallerImpl_CreateRecord(WORD wFlags,
HRESULT
hr
;
HRESULT
hr
;
VARIANTARG
varg0
;
VARIANTARG
varg0
;
MSIHANDLE
hrec
;
MSIHANDLE
hrec
;
IDispatch
*
dispatch
;
if
(
!
(
wFlags
&
DISPATCH_METHOD
))
if
(
!
(
wFlags
&
DISPATCH_METHOD
))
return
DISP_E_MEMBERNOTFOUND
;
return
DISP_E_MEMBERNOTFOUND
;
...
@@ -1700,11 +1695,7 @@ static HRESULT InstallerImpl_CreateRecord(WORD wFlags,
...
@@ -1700,11 +1695,7 @@ static HRESULT InstallerImpl_CreateRecord(WORD wFlags,
if
(
!
hrec
)
if
(
!
hrec
)
return
DISP_E_EXCEPTION
;
return
DISP_E_EXCEPTION
;
hr
=
create_record
(
hrec
,
&
dispatch
);
return
create_record
(
hrec
,
&
V_DISPATCH
(
pVarResult
));
if
(
SUCCEEDED
(
hr
))
V_DISPATCH
(
pVarResult
)
=
dispatch
;
return
hr
;
}
}
static
HRESULT
InstallerImpl_OpenPackage
(
AutomationObject
*
This
,
static
HRESULT
InstallerImpl_OpenPackage
(
AutomationObject
*
This
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment