mshtml: Don't hold ref to the created window in the FrameBase.

Note that for the case when mozwindow_to_window returns an existing window, no ref is added to it anyway, so this is just leaking. Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

mshtml: Don't hold ref to the created window in the FrameBase.
355eb6b9 · Gabriel Ivăncescu · Alexandre Julliard · 6a1b12bd · 355eb6b9
Commit 355eb6b9 authored Jan 03, 2023 by Gabriel Ivăncescu Committed by Alexandre Julliard Jan 24, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

htmlframe.c dlls/mshtml/htmlframe.c +6 -1

No files found.
--- a/dlls/mshtml/htmlframe.c
+++ b/dlls/mshtml/htmlframe.c
@@ -48,9 +48,14 @@ static HRESULT set_frame_doc(HTMLFrameBase *frame, nsIDOMDocument *nsdoc)
        return E_FAIL;

    window = mozwindow_to_window(mozwindow);
-    if(!window && frame->element.node.doc->browser)
+    if(!window && frame->element.node.doc->browser) {
        hres = create_outer_window(frame->element.node.doc->browser, mozwindow,
                frame->element.node.doc->outer_window, &window);
+
+        /* Don't hold ref to the created window; the parent keeps ref to it */
+        if(SUCCEEDED(hres))
+            IHTMLWindow2_Release(&window->base.IHTMLWindow2_iface);
+    }
    mozIDOMWindowProxy_Release(mozwindow);
    if(FAILED(hres))
        return hres;