winemenubuilder: Only extract icons when association changed.

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winemenubuilder: Only extract icons when association changed.
3603478b · Rémi Bernon · Alexandre Julliard · a600d7ec · 3603478b
Commit 3603478b authored Nov 13, 2020 by Rémi Bernon Committed by Alexandre Julliard Nov 13, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

winemenubuilder.c programs/winemenubuilder/winemenubuilder.c +7 -1

No files found.
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -2657,7 +2657,7 @@ static BOOL generate_associations(const char *xdg_data_home, const char *package

            executableW = assoc_query(ASSOCSTR_EXECUTABLE, extensionW, openW);
            if (executableW)
-                openWithIconA = extract_icon(executableW, 0, NULL, FALSE);
+                openWithIconA = compute_native_identifier(0, executableW);

            friendlyAppNameW = assoc_query(ASSOCSTR_FRIENDLYAPPNAME, extensionW, openW);
            if (friendlyAppNameW)
@@ -2730,6 +2730,12 @@ static BOOL generate_associations(const char *xdg_data_home, const char *package
                }
            }

+            if (hasChanged && openWithIconA)
+            {
+                char *outputIconA = extract_icon(executableW, 0, openWithIconA, FALSE);
+                HeapFree(GetProcessHeap(), 0, outputIconA);
+            }
+
        end:
            HeapFree(GetProcessHeap(), 0, extensionA);
            HeapFree(GetProcessHeap(), 0, commandW);