Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
36cf7b3d
Commit
36cf7b3d
authored
Jul 17, 2023
by
Alex Henrie
Committed by
Alexandre Julliard
Jul 18, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32: Free item lists with ILFree.
parent
c79ffafc
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
20 additions
and
20 deletions
+20
-20
clipboard.c
dlls/shell32/clipboard.c
+2
-2
cpanelfolder.c
dlls/shell32/cpanelfolder.c
+3
-3
pidl.c
dlls/shell32/pidl.c
+1
-1
shfldr_desktop.c
dlls/shell32/shfldr_desktop.c
+3
-3
shfldr_fs.c
dlls/shell32/shfldr_fs.c
+4
-4
shfldr_mycomp.c
dlls/shell32/shfldr_mycomp.c
+3
-3
shfldr_netplaces.c
dlls/shell32/shfldr_netplaces.c
+2
-2
shlview_cmenu.c
dlls/shell32/shlview_cmenu.c
+2
-2
No files found.
dlls/shell32/clipboard.c
View file @
36cf7b3d
...
...
@@ -165,7 +165,7 @@ HGLOBAL RenderFILENAMEA (LPITEMIDLIST pidlRoot, LPITEMIDLIST * apidl, UINT cidl)
return
0
;
bSuccess
=
SHGetPathFromIDListA
(
pidl
,
szTemp
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
if
(
!
bSuccess
)
return
0
;
...
...
@@ -197,7 +197,7 @@ HGLOBAL RenderFILENAMEW (LPITEMIDLIST pidlRoot, LPITEMIDLIST * apidl, UINT cidl)
return
0
;
bSuccess
=
SHGetPathFromIDListW
(
pidl
,
szTemp
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
if
(
!
bSuccess
)
return
0
;
...
...
dlls/shell32/cpanelfolder.c
View file @
36cf7b3d
...
...
@@ -636,18 +636,18 @@ static HRESULT WINAPI ISF_ControlPanel_fnGetUIObjectOf(IShellFolder2 *iface, HWN
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconA
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconA_Constructor
(
pidl
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconW
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconW_Constructor
(
pidl
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
hr
=
S_OK
;
}
else
if
((
IsEqualIID
(
riid
,
&
IID_IShellLinkW
)
||
IsEqualIID
(
riid
,
&
IID_IShellLinkA
))
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
hr
=
IShellLink_ConstructFromFile
(
NULL
,
riid
,
pidl
,
&
pObj
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
}
else
{
hr
=
E_NOINTERFACE
;
}
...
...
dlls/shell32/pidl.c
View file @
36cf7b3d
...
...
@@ -1328,7 +1328,7 @@ HRESULT WINAPI SHBindToFolderIDListParent(IShellFolder *psf, LPCITEMIDLIST pidl,
LPITEMIDLIST
pidlParent
=
ILClone
(
pidl
);
ILRemoveLastID
(
pidlParent
);
hr
=
IShellFolder_BindToObject
(
psf
,
pidlParent
,
NULL
,
riid
,
ppv
);
SHFree
(
pidlParent
);
ILFree
(
pidlParent
);
}
if
(
psfDesktop
)
...
...
dlls/shell32/shfldr_desktop.c
View file @
36cf7b3d
...
...
@@ -530,14 +530,14 @@ static HRESULT WINAPI ISF_Desktop_fnGetUIObjectOf (IShellFolder2 * iface,
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconA_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconW
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconW_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IDropTarget
)
&&
(
cidl
>=
1
))
...
...
@@ -550,7 +550,7 @@ static HRESULT WINAPI ISF_Desktop_fnGetUIObjectOf (IShellFolder2 * iface,
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
hr
=
IShellLink_ConstructFromFile
(
NULL
,
riid
,
pidl
,
&
pObj
);
SHFree
(
pidl
);
ILFree
(
pidl
);
}
else
hr
=
E_NOINTERFACE
;
...
...
dlls/shell32/shfldr_fs.c
View file @
36cf7b3d
...
...
@@ -710,12 +710,12 @@ IShellFolder_fnGetUIObjectOf (IShellFolder2 * iface,
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconA
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconA_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconW
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconW_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IDropTarget
)
&&
(
cidl
>=
1
))
{
hr
=
IShellFolder2_QueryInterface
(
iface
,
&
IID_IDropTarget
,
...
...
@@ -724,7 +724,7 @@ IShellFolder_fnGetUIObjectOf (IShellFolder2 * iface,
IsEqualIID
(
riid
,
&
IID_IShellLinkA
))
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
hr
=
IShellLink_ConstructFromFile
(
NULL
,
riid
,
pidl
,
&
pObj
);
SHFree
(
pidl
);
ILFree
(
pidl
);
}
else
{
hr
=
E_NOINTERFACE
;
}
...
...
@@ -1305,7 +1305,7 @@ ISFHelper_fnDeleteItems (ISFHelper * iface, UINT cidl, LPCITEMIDLIST * apidl)
{
LPITEMIDLIST
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
i
]);
SHChangeNotify
(
wEventId
,
SHCNF_IDLIST
,
pidl
,
NULL
);
SH
Free
(
pidl
);
IL
Free
(
pidl
);
}
wszCurrentPath
+=
lstrlenW
(
wszCurrentPath
)
+
1
;
...
...
dlls/shell32/shfldr_mycomp.c
View file @
36cf7b3d
...
...
@@ -527,14 +527,14 @@ static HRESULT WINAPI ISF_MyComputer_fnGetUIObjectOf (IShellFolder2 * iface,
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconA_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconW
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconW_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IDropTarget
)
&&
(
cidl
>=
1
))
...
...
@@ -547,7 +547,7 @@ static HRESULT WINAPI ISF_MyComputer_fnGetUIObjectOf (IShellFolder2 * iface,
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
hr
=
IShellLink_ConstructFromFile
(
NULL
,
riid
,
pidl
,
&
pObj
);
SHFree
(
pidl
);
ILFree
(
pidl
);
}
else
hr
=
E_NOINTERFACE
;
...
...
dlls/shell32/shfldr_netplaces.c
View file @
36cf7b3d
...
...
@@ -424,14 +424,14 @@ static HRESULT WINAPI ISF_NetworkPlaces_fnGetUIObjectOf (IShellFolder2 * iface,
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconA_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IExtractIconW
)
&&
(
cidl
==
1
))
{
pidl
=
ILCombine
(
This
->
pidlRoot
,
apidl
[
0
]);
pObj
=
(
LPUNKNOWN
)
IExtractIconW_Constructor
(
pidl
);
SHFree
(
pidl
);
ILFree
(
pidl
);
hr
=
S_OK
;
}
else
if
(
IsEqualIID
(
riid
,
&
IID_IDropTarget
)
&&
(
cidl
>=
1
))
...
...
dlls/shell32/shlview_cmenu.c
View file @
36cf7b3d
...
...
@@ -282,7 +282,7 @@ static void DoOpenExplore(ContextMenu *This, HWND hwnd, LPCSTR verb)
sei
.
nShow
=
SW_SHOWNORMAL
;
sei
.
lpVerb
=
verb
;
ShellExecuteExA
(
&
sei
);
SH
Free
(
pidlFQ
);
IL
Free
(
pidlFQ
);
}
/**************************************************************************
...
...
@@ -1150,7 +1150,7 @@ static HRESULT paste_pidls(ContextMenu *This, ITEMIDLIST **pidls, UINT count)
if
(
psfhlpsrc
)
ISFHelper_Release
(
psfhlpsrc
);
IShellFolder_Release
(
psfFrom
);
}
SH
Free
(
pidl_dir
);
IL
Free
(
pidl_dir
);
}
IShellFolder_Release
(
psfDesktop
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment