Commit 37975ba7 authored by Huw Davies's avatar Huw Davies Committed by Alexandre Julliard

comdlg32/tests: Explicitly set the structure size to the nt40 version size.

parent 914353d3
...@@ -93,7 +93,7 @@ static void test_DialogCancel(void) ...@@ -93,7 +93,7 @@ static void test_DialogCancel(void)
ZeroMemory(&ofn, sizeof(ofn)); ZeroMemory(&ofn, sizeof(ofn));
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.hwndOwner = NULL; ofn.hwndOwner = NULL;
ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0"; ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0";
ofn.lpstrFile = szFileName; ofn.lpstrFile = szFileName;
...@@ -266,7 +266,7 @@ static void test_create_view_window2(void) ...@@ -266,7 +266,7 @@ static void test_create_view_window2(void)
char filename[1024] = {0}; char filename[1024] = {0};
DWORD ret; DWORD ret;
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.lpstrFile = filename; ofn.lpstrFile = filename;
ofn.nMaxFile = 1024; ofn.nMaxFile = 1024;
ofn.lpfnHook = create_view_window2_hook; ofn.lpfnHook = create_view_window2_hook;
...@@ -283,7 +283,7 @@ static void test_create_view_template(void) ...@@ -283,7 +283,7 @@ static void test_create_view_template(void)
char filename[1024] = {0}; char filename[1024] = {0};
DWORD ret; DWORD ret;
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.lpstrFile = filename; ofn.lpstrFile = filename;
ofn.nMaxFile = 1024; ofn.nMaxFile = 1024;
ofn.lpfnHook = (LPOFNHOOKPROC)template_hook; ofn.lpfnHook = (LPOFNHOOKPROC)template_hook;
...@@ -531,7 +531,7 @@ todo_wine ...@@ -531,7 +531,7 @@ todo_wine
static void test_resize(void) static void test_resize(void)
{ {
OPENFILENAME ofn = { sizeof(OPENFILENAME)}; OPENFILENAME ofn = { OPENFILENAME_SIZE_VERSION_400 };
char filename[1024] = {0}; char filename[1024] = {0};
DWORD ret; DWORD ret;
int i; int i;
...@@ -633,7 +633,7 @@ static LONG_PTR WINAPI ok_template_hook(HWND dlg, UINT msg, WPARAM wParam, LPARA ...@@ -633,7 +633,7 @@ static LONG_PTR WINAPI ok_template_hook(HWND dlg, UINT msg, WPARAM wParam, LPARA
static void test_ok(void) static void test_ok(void)
{ {
OPENFILENAME ofn = { sizeof(OPENFILENAME)}; OPENFILENAME ofn = { OPENFILENAME_SIZE_VERSION_400 };
char filename[1024] = {0}; char filename[1024] = {0};
char tmpfilename[ MAX_PATH]; char tmpfilename[ MAX_PATH];
char curdir[MAX_PATH]; char curdir[MAX_PATH];
...@@ -843,7 +843,7 @@ static void test_arrange(void) ...@@ -843,7 +843,7 @@ static void test_arrange(void)
return; return;
} }
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.lpstrFile = filename; ofn.lpstrFile = filename;
ofn.nMaxFile = 1024; ofn.nMaxFile = 1024;
ofn.lpfnHook = (LPOFNHOOKPROC)template_hook_arrange; ofn.lpfnHook = (LPOFNHOOKPROC)template_hook_arrange;
...@@ -916,7 +916,7 @@ static void test_getfolderpath(void) ...@@ -916,7 +916,7 @@ static void test_getfolderpath(void)
ZeroMemory(&ofn, sizeof(ofn)); ZeroMemory(&ofn, sizeof(ofn));
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.hwndOwner = NULL; ofn.hwndOwner = NULL;
ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0"; ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0";
ofn.lpstrFile = szFileName; ofn.lpstrFile = szFileName;
...@@ -948,7 +948,7 @@ static void test_resizable2(void) ...@@ -948,7 +948,7 @@ static void test_resizable2(void)
skip( "some interactive resizable dialog tests (set WINETEST_INTERACTIVE=1)\n"); skip( "some interactive resizable dialog tests (set WINETEST_INTERACTIVE=1)\n");
return; return;
} }
ofn.lStructSize = sizeof(ofn); ofn.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofn.lpstrFile = filename; ofn.lpstrFile = filename;
ofn.nMaxFile = 1024; ofn.nMaxFile = 1024;
ofn.lpfnHook = NULL; ofn.lpfnHook = NULL;
...@@ -983,7 +983,7 @@ static void test_resizable2(void) ...@@ -983,7 +983,7 @@ static void test_resizable2(void)
static void test_mru(void) static void test_mru(void)
{ {
ok_wndproc_testcase testcase = {0}; ok_wndproc_testcase testcase = {0};
OPENFILENAME ofn = {sizeof(OPENFILENAME)}; OPENFILENAME ofn = { OPENFILENAME_SIZE_VERSION_400 };
const char *test_dir_name = "C:\\mru_test"; const char *test_dir_name = "C:\\mru_test";
const char *test_file_name = "test.txt"; const char *test_file_name = "test.txt";
const char *test_full_path = "C:\\mru_test\\test.txt"; const char *test_full_path = "C:\\mru_test\\test.txt";
...@@ -1069,7 +1069,7 @@ static void test_extension_helper(OPENFILENAME* ofn, const char *filter, ...@@ -1069,7 +1069,7 @@ static void test_extension_helper(OPENFILENAME* ofn, const char *filter,
static void test_extension(void) static void test_extension(void)
{ {
OPENFILENAME ofn = { sizeof(OPENFILENAME)}; OPENFILENAME ofn = { OPENFILENAME_SIZE_VERSION_400 };
char filename[1024] = {0}; char filename[1024] = {0};
char curdir[MAX_PATH]; char curdir[MAX_PATH];
unsigned int i; unsigned int i;
...@@ -1093,7 +1093,6 @@ static void test_extension(void) ...@@ -1093,7 +1093,6 @@ static void test_extension(void)
boolret = GetCurrentDirectoryA(sizeof(curdir), curdir); boolret = GetCurrentDirectoryA(sizeof(curdir), curdir);
ok(boolret, "Failed to get current dir err %d\n", GetLastError()); ok(boolret, "Failed to get current dir err %d\n", GetLastError());
ofn.lStructSize = sizeof(ofn);
ofn.hwndOwner = NULL; ofn.hwndOwner = NULL;
ofn.lpstrFile = filename; ofn.lpstrFile = filename;
ofn.nMaxFile = MAX_PATH; ofn.nMaxFile = MAX_PATH;
...@@ -1176,7 +1175,7 @@ static void test_null_filename(void) ...@@ -1176,7 +1175,7 @@ static void test_null_filename(void)
'A','l','l','\0','*','\0','\0'}; 'A','l','l','\0','*','\0','\0'};
DWORD ret; DWORD ret;
ofnA.lStructSize = sizeof(ofnA); ofnA.lStructSize = OPENFILENAME_SIZE_VERSION_400A;
ofnA.lpstrFile = NULL; ofnA.lpstrFile = NULL;
ofnA.nMaxFile = 0; ofnA.nMaxFile = 0;
ofnA.nFileOffset = 0xdead; ofnA.nFileOffset = 0xdead;
...@@ -1207,7 +1206,7 @@ static void test_null_filename(void) ...@@ -1207,7 +1206,7 @@ static void test_null_filename(void)
ok(ofnA.nFileExtension == 0, "ofnA.nFileExtension is 0x%x, should be 0\n", ofnA.nFileExtension); ok(ofnA.nFileExtension == 0, "ofnA.nFileExtension is 0x%x, should be 0\n", ofnA.nFileExtension);
/* unicode tests */ /* unicode tests */
ofnW.lStructSize = sizeof(ofnW); ofnW.lStructSize = OPENFILENAME_SIZE_VERSION_400W;
ofnW.lpstrFile = NULL; ofnW.lpstrFile = NULL;
ofnW.nMaxFile = 0; ofnW.nMaxFile = 0;
ofnW.nFileOffset = 0xdead; ofnW.nFileOffset = 0xdead;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment