services: Hold scmdatabase lock while checking marked_for_delete.

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

services: Hold scmdatabase lock while checking marked_for_delete.
38a09f9c · Sebastian Lackner · Alexandre Julliard · 4a3d7126 · 38a09f9c
Commit 38a09f9c authored Mar 16, 2016 by Sebastian Lackner Committed by Alexandre Julliard Mar 16, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

services.c programs/services/services.c +5 -3

No files found.
--- a/programs/services/services.c
+++ b/programs/services/services.c
@@ -456,13 +456,15 @@ struct service_entry *scmdatabase_find_service_by_displayname(struct scmdatabase

 void release_service(struct service_entry *service)
 {
+    struct scmdatabase *db = service->db;
+
+    scmdatabase_lock(db);
    if (InterlockedDecrement(&service->ref_count) == 0 && is_marked_for_delete(service))
    {
-        scmdatabase_lock(service->db);
-        scmdatabase_remove_service(service->db, service);
-        scmdatabase_unlock(service->db);
+        scmdatabase_remove_service(db, service);
        free_service_entry(service);
    }
+    scmdatabase_unlock(db);
 }

 static DWORD scmdatabase_create(struct scmdatabase **db)