d3d8/tests: Properly check whether creating a device succeeded in test_flip().

Perhaps CreateDevice() should clear the pointer on failure, but that's not documented behaviour, and Wine currently doesn't. Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d3d8/tests: Properly check whether creating a device succeeded in test_flip().
3932b2f2 · Henri Verbeet · Alexandre Julliard · 86805c3d · 3932b2f2
Commit 3932b2f2 authored Sep 22, 2018 by Henri Verbeet Committed by Alexandre Julliard Sep 24, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

visual.c dlls/d3d8/tests/visual.c +2 -3

No files found.
--- a/dlls/d3d8/tests/visual.c
+++ b/dlls/d3d8/tests/visual.c
@@ -8154,9 +8154,8 @@ static void test_flip(void)
    present_parameters.Windowed = TRUE;
    present_parameters.BackBufferCount = 3;
    present_parameters.Flags = D3DPRESENTFLAG_LOCKABLE_BACKBUFFER;
-    hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL,
-            window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device);
-    if (!device)
+    if (FAILED(hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL,
+            window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device)))
    {
        skip("Failed to create a D3D device, skipping tests.\n");
        IDirect3D8_Release(d3d);