ole32: Check for NULL parameter in ReleaseStgMedium().

libcef can call ReleaseStgMedium( NULL ) Signed-off-by: Chao Long <longchao@uniontech.com> Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ole32: Check for NULL parameter in ReleaseStgMedium().
3956b526 · Chao Long · Alexandre Julliard · c1c86f66 · 3956b526 · 3956b526
Commit 3956b526 authored Sep 28, 2020 by Chao Long Committed by Alexandre Julliard Sep 28, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

ole2.c dlls/ole32/ole2.c +2 -0

ole2.c dlls/ole32/tests/ole2.c +6 -0

No files found.
--- a/dlls/ole32/ole2.c
+++ b/dlls/ole32/ole2.c
@@ -2023,6 +2023,8 @@ found:
 void WINAPI ReleaseStgMedium(
  STGMEDIUM* pmedium)
 {
+  if (!pmedium) return;
+
  switch (pmedium->tymed)
  {
    case TYMED_HGLOBAL:

--- a/dlls/ole32/tests/ole2.c
+++ b/dlls/ole32/tests/ole2.c
@@ -4610,6 +4610,11 @@ static void test_OleCreateStaticFromData(void)
    IStorage_Release(storage);
 }

+static void test_ReleaseStgMedium( void )
+{
+    ReleaseStgMedium( NULL );
+}
+
 START_TEST(ole2)
 {
    DWORD dwRegister;
@@ -4661,6 +4666,7 @@ START_TEST(ole2)
    test_data_cache_save_data();
    test_data_cache_contents();
    test_OleCreateStaticFromData();
+    test_ReleaseStgMedium();

    CoUninitialize();
 }