strmbase: Don't hold the filter lock while calling IPin::NewSegment().

It's not safe to hold the filter lock from a streaming thread, and anyway we aren't protecting anything that needs locking. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

strmbase: Don't hold the filter lock while calling IPin::NewSegment().
3b7ce569 · Zebediah Figura · Alexandre Julliard · 2935bab9 · 3b7ce569
Commit 3b7ce569 authored Nov 30, 2019 by Zebediah Figura Committed by Alexandre Julliard Dec 02, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

transform.c dlls/strmbase/transform.c +0 -2

No files found.
--- a/dlls/strmbase/transform.c
+++ b/dlls/strmbase/transform.c
@@ -495,12 +495,10 @@ static HRESULT WINAPI TransformFilter_InputPin_NewSegment(IPin * iface, REFERENC
    TRACE("iface %p, start %s, stop %s, rate %.16e.\n",
            iface, debugstr_time(tStart), debugstr_time(tStop), dRate);

-    EnterCriticalSection(&pTransform->filter.csFilter);
    if (pTransform->pFuncsTable->pfnNewSegment)
        hr = pTransform->pFuncsTable->pfnNewSegment(pTransform, tStart, tStop, dRate);
    if (SUCCEEDED(hr))
        hr = BaseInputPinImpl_NewSegment(iface, tStart, tStop, dRate);
-    LeaveCriticalSection(&pTransform->filter.csFilter);
    return hr;
 }