Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
4023e012
Commit
4023e012
authored
Aug 19, 2010
by
Nikolay Sivov
Committed by
Alexandre Julliard
Aug 20, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32/imagelist: Fix failure code for IImageList_Remove().
parent
5ee4441c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
imagelist.c
dlls/comctl32/imagelist.c
+1
-1
imagelist.c
dlls/comctl32/tests/imagelist.c
+3
-3
No files found.
dlls/comctl32/imagelist.c
View file @
4023e012
...
...
@@ -3314,7 +3314,7 @@ static HRESULT WINAPI ImageListImpl_Draw(IImageList *iface,
static
HRESULT
WINAPI
ImageListImpl_Remove
(
IImageList
*
iface
,
int
i
)
{
return
(
ImageList_Remove
((
HIMAGELIST
)
iface
,
i
)
==
0
)
?
E_
FAIL
:
S_OK
;
return
(
ImageList_Remove
((
HIMAGELIST
)
iface
,
i
)
==
0
)
?
E_
INVALIDARG
:
S_OK
;
}
static
HRESULT
WINAPI
ImageListImpl_GetIcon
(
IImageList
*
iface
,
int
i
,
UINT
flags
,
...
...
dlls/comctl32/tests/imagelist.c
View file @
4023e012
...
...
@@ -1493,7 +1493,7 @@ static void test_IImageList_Add_Remove(void)
/* remove when nothing exists */
hr
=
IImageList_Remove
(
imgl
,
0
);
todo_wine
ok
(
hr
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
ok
(
hr
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
/* removing everything from an empty imagelist should succeed */
hr
=
IImageList_Remove
(
imgl
,
-
1
);
...
...
@@ -1505,7 +1505,7 @@ static void test_IImageList_Add_Remove(void)
ok
(
IImageList_ReplaceIcon
(
imgl
,
-
1
,
hicon3
,
&
ret
)
==
S_OK
&&
(
ret
==
2
),
"failed to add icon3
\n
"
);
/* remove an index out of range */
todo_wine
ok
(
IImageList_Remove
(
imgl
,
4711
)
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
ok
(
IImageList_Remove
(
imgl
,
4711
)
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
/* remove three */
ok
(
IImageList_Remove
(
imgl
,
0
)
==
S_OK
,
"can't remove 0
\n
"
);
...
...
@@ -1513,7 +1513,7 @@ static void test_IImageList_Add_Remove(void)
ok
(
IImageList_Remove
(
imgl
,
0
)
==
S_OK
,
"can't remove 0
\n
"
);
/* remove one extra */
todo_wine
ok
(
IImageList_Remove
(
imgl
,
0
)
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
ok
(
IImageList_Remove
(
imgl
,
0
)
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
IImageList_Release
(
imgl
);
ok
(
DestroyIcon
(
hicon1
),
"icon 1 wasn't deleted
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment