Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
46229acd
Commit
46229acd
authored
Nov 30, 2011
by
Frédéric Delanoy
Committed by
Alexandre Julliard
Dec 01, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
gameux: Do not use RegCloseKey on invalid/uninitialized registry key handle (Coverity).
parent
90415ebd
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
7 deletions
+8
-7
gamestatistics.c
dlls/gameux/gamestatistics.c
+8
-7
No files found.
dlls/gameux/gamestatistics.c
View file @
46229acd
...
@@ -388,17 +388,18 @@ static HRESULT GAMEUX_getAppIdFromGDFPath(
...
@@ -388,17 +388,18 @@ static HRESULT GAMEUX_getAppIdFromGDFPath(
/* game is registered, let's read it's application id from registry */
/* game is registered, let's read it's application id from registry */
hr
=
GAMEUX_buildGameRegistryPath
(
installScope
,
&
instanceId
,
&
lpRegistryPath
);
hr
=
GAMEUX_buildGameRegistryPath
(
installScope
,
&
instanceId
,
&
lpRegistryPath
);
if
(
SUCCEEDED
(
hr
))
if
(
SUCCEEDED
(
hr
))
{
hr
=
HRESULT_FROM_WIN32
(
RegOpenKeyExW
(
HKEY_LOCAL_MACHINE
,
hr
=
HRESULT_FROM_WIN32
(
RegOpenKeyExW
(
HKEY_LOCAL_MACHINE
,
lpRegistryPath
,
0
,
KEY_READ
|
KEY_WOW64_64KEY
,
&
hKey
));
lpRegistryPath
,
0
,
KEY_READ
|
KEY_WOW64_64KEY
,
&
hKey
));
if
(
SUCCEEDED
(
hr
))
{
if
(
SUCCEEDED
(
hr
))
hr
=
HRESULT_FROM_WIN32
(
RegGetValueW
(
hKey
,
hr
=
HRESULT_FROM_WIN32
(
RegGetValueW
(
hKey
,
NULL
,
sApplicationId
,
RRF_RT_REG_SZ
,
NULL
,
sApplicationId
,
RRF_RT_REG_SZ
,
NULL
,
lpApplicationId
,
&
dwLength
));
NULL
,
lpApplicationId
,
&
dwLength
));
RegCloseKey
(
hKey
);
}
}
HeapFree
(
GetProcessHeap
(),
0
,
lpRegistryPath
);
HeapFree
(
GetProcessHeap
(),
0
,
lpRegistryPath
);
RegCloseKey
(
hKey
);
TRACE
(
"found app id: %s, return: %#x
\n
"
,
debugstr_w
(
lpApplicationId
),
hr
);
TRACE
(
"found app id: %s, return: %#x
\n
"
,
debugstr_w
(
lpApplicationId
),
hr
);
return
hr
;
return
hr
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment