windowscodecs: Do not leak profile on errors (Coverity).

4641ed5c · Marcus Meissner · Alexandre Julliard · 339ec9c4 · 4641ed5c
Commit 4641ed5c authored Mar 15, 2013 by Marcus Meissner Committed by Alexandre Julliard Mar 25, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

colorcontext.c dlls/windowscodecs/colorcontext.c +10 -2

No files found.
--- a/dlls/windowscodecs/colorcontext.c
+++ b/dlls/windowscodecs/colorcontext.c
@@ -126,8 +126,16 @@ static HRESULT load_profile(const WCHAR *filename, BYTE **profile, UINT *len)
    }
    ret = ReadFile(handle, *profile, size.u.LowPart, &count, NULL);
    CloseHandle(handle);
-    if (!ret) return HRESULT_FROM_WIN32(GetLastError());
+    if (!ret) {
-    if (count != size.u.LowPart) return E_FAIL;
+        HeapFree (GetProcessHeap(),0,*profile);
+        *profile = NULL;
+        return HRESULT_FROM_WIN32(GetLastError());
+    }
+    if (count != size.u.LowPart) {
+        HeapFree (GetProcessHeap(),0,*profile);
+        *profile = NULL;
+        return E_FAIL;
+    }
    *len = count;
    return S_OK;
 }